Skip to content
  • Sponsor nats-io/nats-server

  • Notifications You must be signed in to change notification settings
  • Fork 1.5k
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JetStream pull over export service response type stream #6172

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update client.go
roeschter committed Nov 25, 2024

Verified

This commit was signed with the committer’s verified signature.
commit fb93fd0ca75ed9f7008ea398fd0851227e226d9b
3 changes: 2 additions & 1 deletion server/client.go
Original file line number Diff line number Diff line change
@@ -4334,14 +4334,15 @@ func (c *client) processServiceImport(si *serviceImport, acc *Account, msg []byt
// For now we can't do $JS.ACK since that breaks pull consumers across accounts.
if !bytes.HasPrefix(c.pa.reply, []byte(jsAckPre)) {
// We need to know if this is a Jetstream message stream when deciding if we should remove the import
isJetstreamMsg = true
isJetstreamMsg = false
if rsi = c.setupResponseServiceImport(acc, si, tracking, headers); rsi != nil {
nrr = []byte(rsi.from)
}
} else {
// This only happens when we do a pull subscriber that trampolines through another account.
// Normally this code is not called.
nrr = c.pa.reply
isJetstreamMsg = true
}
} else if !isResponse && si.latency != nil && tracking {
// Check to see if this was a bad request with no reply and we were supposed to be tracking.