Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] Max streams reached with parallel stream creation #6502

Merged
merged 1 commit into from
Feb 12, 2025
Merged

[FIXED] Max streams reached with parallel stream creation #6502

merged 1 commit into from
Feb 12, 2025

Conversation

MauriceVanVeen
Copy link
Member

Maximum streams reached errors would be returned when creating (the same) streams in parallel:

  • if max streams = 1, the second create request would fail as the previous create request being inflight made it exceed the limit, even if it was about the same stream
  • if max streams > 1, if the streams already existed would count the streams twice, once for the streams existing already, and another time due to being inflight

Signed-off-by: Maurice van Veen [email protected]

@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner February 12, 2025 11:14
neilalexander
neilalexander approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

derekcollison
derekcollison approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 3efc8de into main Feb 12, 2025
5 checks passed
@derekcollison derekcollison deleted the maurice/max-streams-reached branch February 12, 2025 16:38
@neilalexander neilalexander mentioned this pull request Feb 12, 2025
Merged
neilalexander added a commit that referenced this pull request Feb 12, 2025
@neilalexander
Cherry-picks for 2.10.26-RC.3 (#6504)
7321c8a 
Includes the following:

- #6492
- #6494
- #6498
- #6500
- #6499
- #6502

Signed-off-by: Neil Twigg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

@neilalexander neilalexander neilalexander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MauriceVanVeen @derekcollison @neilalexander