Ticket 116 - mockup for API call #386
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acouch
reviewed
May 14, 2025
There was a problem hiding this comment.
(nit) The "health" page is often used to make sure the application is working, think we still use that on grants.gov https://github.com/HHS/simpler-grants-gov/blob/main/frontend/src/app/%5Blocale%5D/health/page.tsx . I would recommend keeping it as is and creating a separate page for this.
acouch
reviewed
May 14, 2025
| @@ -1,3 +1,37 @@ | |||
| 'use client' | |||
There was a problem hiding this comment.
(nit) This means the whole may be rendered in the client. Alternatively the members list could be a client component that the page uses so the page could still be rendered server side.
acouch
reviewed
May 14, 2025
| export default function Page() { | ||
| return <>healthy</>; | ||
| const [members, setMembers] = useState<Member[]>([]); |
There was a problem hiding this comment.
It would be nice to have an error and loading states.
acouch
reviewed
May 15, 2025
|
|
||
| useEffect(() => { | ||
| getMembers(); | ||
| }, []); |
There was a problem hiding this comment.
getMembers should be a dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Resolves #116
Changes
Added in an API example
Context for reviewers
Created a new file for the service calls and called it on the health page in order to display member information
Testing