Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trucknavigation #1106

Open
wants to merge 137 commits into
base: trunk
Choose a base branch
from
Open

Trucknavigation #1106

wants to merge 137 commits into from

Conversation

OLFDB
Copy link
Contributor

@OLFDB OLFDB commented Apr 3, 2021

The navit routing engine is capable of truck navigation, taking into account sizes and weights (including axle weights) already.
This PR will enable maptool to provide the data needed by the routing engine in the map binfiles.

The truck profile in navit.xml was enhanced by supplying values for turn_around_penalty and turn_around_penalty2 to prevent uturns during routing.

@OLFDB OLFDB changed the title [WIP]Trucknavigation Trucknavigation May 23, 2021
@OLFDB
Copy link
Contributor Author

OLFDB commented May 23, 2021

Finally the routing taking into account the low emissions zones is working.
I think the PR is finished now.

Bildschirmaufnahme.mov

Copy link
Member

@jkoan jkoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the other comments i noticed that that your branch needs to be rebased, are you able to do so?

Comment on lines +2242 to +2245
if (this->active)
path = graphics_icon_path("sound_on.png");
else
path = graphics_icon_path("sound_off.png");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly speaking this dosn't belong into this PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, do I need to remove it?

Comment on lines +34 to +66
enum emissionclass {
//Truck
Euro_0,
Euro_1,
Euro_2,
Euro_3,
Euro_4,
Euro_5,
Euro_6,
//Car, use label colors and Euro_6d_TEMP for now
Cat_RED,
Cat_YLW,
Cat_GRN,
Euro_6d_TEMP,
EMISSION_CLASS_MAX,
};

static struct emissionclasstxt {
char *classes[EMISSION_CLASS_MAX];
} ectxt = {
"Euro 0",
"Euro 1",
"Euro 2",
"Euro 3",
"Euro 4",
"Euro 5",
"Euro 6",
"Red Label",
"Yellow Label",
"Green Label",
"Euro 6d temp"
};

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be really specific to Germany, what about other country's?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Euro x classes are valid in EU, not only in Germany. For the labels you are right.
The purpose of the emission class was to use it for routing with the low emission zones. As the access tag for the lezs is missing often, it is not usable at the moment. That's why I added the "Enter low emission zone" value that is used for routing now.

@@ -35,7 +35,7 @@ echo "Setting up all Variables"
UUID=${RANDOM}-${RANDOM}-${RANDOM}-${RANDOM}
TMP_DIR=$(mktemp -d)
CIRCLECI_API_BASE="https://circleci.com/api/v1.1/"
NAVIT_DOWNLOAD_CENTER_REPO="[email protected]:navit-gps/download-center"
NAVIT_DOWNLOAD_CENTER_REPO="[email protected]:OLFDB/download-center"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above. Would like to keep it in my fork only, so my CI build is working. Is that somehow possible?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to revert d670c8c for this

@OLFDB
Copy link
Contributor Author

OLFDB commented Jul 23, 2021

Good work. I'm looking forward for the low emmission zones, as those can be very interesting on map.

@metalstrolch: When testing with larger maps having more than one low emission zone, the detection of the lezs is not working properly. I think I need somehow to have a reference to the tiles containing the lez to be able to select the correct polygon to test against during route calculation. Could you help me with that? Maybe it would also be a good idea to flag each street if it is in an lez in maptool. That would improve performance during route calculation later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants