-
Couldn't load subscription status.
- Fork 176
Merge core changes from qml-gui-wip #831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
viktorgino
wants to merge
10
commits into
trunk
Choose a base branch
from
PR_830
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
44296e7
Add:core:Add item_is_poi macro
viktorgino b35bf7d
Add:core:Add navit_drag_map function
viktorgino a1bdea4
Fix:core:Make navit_set_center_cursor_draw globally accessible
viktorgino 56f9a35
Fix:core:Redraw map when the orientation attribute is changed
viktorgino 7700a92
Fix:core:Wrap item_is_poi macro in brackets
viktorgino 7b9e302
Merge branch 'trunk' into PR_830
pgrandin 41d53f3
Merge branch 'trunk' into PR_830
jkoan beb558a
Merge branch 'trunk' into PR_830
jkoan 82881fd
Merge branch 'trunk' into PR_830
jkoan 39b6e79
Merge branch 'trunk' into PR_830
jkoan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this shall get a "public" function, I suggest to do some sanity checking here, like aborting if some of the parameters is NULL, issuing some err message if this is not expected. May help future users of this in calling the function right.