ruff: 0.12.10 fixes #892
Merged
ruff: 0.12.10 fixes #892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: phanirithvij <[email protected]>
Signed-off-by: phanirithvij <[email protected]>
phanirithvij
force-pushed
the
ruff-fmt-change
branch
from
af1cb17 to
e715abb
Compare
phanirithvij
commented
Sep 13, 2025
| if command.startswith("ruff"): | ||
| return [ | ||
| ( | ||
| rf"(?<=--> {re.escape(relative_path)}:)\d+" |
Contributor
Author
There was a problem hiding this comment.
I am a bit confused what's required here.
I tried rf"(?<=\s+--> {re.escape(relative_path)}:)\d+" but it fails because re.PatternError: look-behind requires fixed-width pattern. so \s+ is not allowed.
I saw both _--> and __--> in the ruff tests.
Collaborator
There was a problem hiding this comment.
thanks for your fix
I'm not sure what you mean here, sorry - did you figure out a fix?
phanirithvij
commented
Sep 13, 2025
| ) | ||
|
|
||
| # simple dedent of '\s+-->' | ||
| out = "\n".join(sorted([x.lstrip() for x in output])) |
Contributor
Author
There was a problem hiding this comment.
so I am doing lstrip here to handle arbitrary indentation
Contributor
Author
There was a problem hiding this comment.
Yes, my fix for the above issue is here.
MarcoGorelli
approved these changes
Oct 31, 2025
Collaborator
MarcoGorelli
left a comment
MarcoGorelli
left a comment
There was a problem hiding this comment.
sure, no objections, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #891