Make Commitments.SpendableBalance HTLC-aware #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit the BouncyCastle build is uploaded as DotNetLightning.Kiss and the native build is not uploaded.
Commitments.SpendableBalance now takes into account HTLC fees when calculating the maximum payment size.
knocte
pushed a commit
that referenced
this pull request
Jun 14, 2020
Add the UInt48, RevocationKey, CommitmentPubKey, CommitmentSeed and RevocationSet types. A RevocationKey is a secret key that can be used to revoke a transaction. It's shared in the revoke_and_ack message and stored in the user's wallet in a RevocationSet. A CommitmentPubKey is the public key of a RevocationKey, also known as a "per commitment point". A CommitmentSeed is the master revocation key for a side of a channel and can be used to derive all the revocation keys for that side of that channel. A RevocationSet stores a set of revocation keys in a compact form specified in BOLT #3 which allows earlier keys to be derived from later keys.
knocte
force-pushed
the
master
branch
2 times, most recently
from
6a284cb to
407936a
Compare
knocte
force-pushed
the
master
branch
2 times, most recently
from
a1e8ff2 to
205ccbc
Compare
knocte
force-pushed
the
master
branch
6 times, most recently
from
135c9bb to
02564ea
Compare
knocte
pushed a commit
that referenced
this pull request
Nov 6, 2020
Rather than using a PubKey to represent a per-commitment-point, use the type that's specifically for this.
knocte
force-pushed
the
master
branch
5 times, most recently
from
1aaef3e to
4d462bd
Compare
knocte
force-pushed
the
master
branch
3 times, most recently
from
f9839d5 to
6281acc
Compare
knocte
force-pushed
the
master
branch
3 times, most recently
from
9f9f73e to
2883c78
Compare
canndrew
force-pushed
the
master
branch
4 times, most recently
from
f817da9 to
0340b0b
Compare
knocte
force-pushed
the
master
branch
3 times, most recently
from
0389f6a to
60d2401
Compare
knocte
force-pushed
the
master
branch
4 times, most recently
from
419cd8d to
f0461b4
Compare
knocte
force-pushed
the
master
branch
4 times, most recently
from
37fe5af to
1f418fe
Compare
knocte
force-pushed
the
master
branch
5 times, most recently
from
bd34034 to
b67e13f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds off of #2.
Make
Commitments.SpendableBalanceconsider HTLC fees when calculating the maximum payment size.