-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for NumericUnderscores extensions from CLI/config #1435
base: master
Are you sure you want to change the base?
Conversation
@ndmitchell Is there a different way you'd like me to approach this problem? I'm happy to rework this. |
src/Hint/NumLiteral.hs
Outdated
concatMap suggestUnderscore . universeBi | ||
else | ||
const [] | ||
where | ||
moduleExtensions = toList (extensions $ modComments modu) | ||
activeExtensions = hlintExtensions modu <> toList moduleExtensions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the toList
here is redundant - you've already called toList
inside moduleExtensions
, right?
Thanks, @googleson78! I'll start working on a patch. |
Sorry it took me so disastrously long to get to this diff - it feel off my radar. I updated the merge conflicts, but didn't test after (did it in the github UI). I can see how this would apply to people using the API, but as far as I can tell, this won't have any impact on the command line users? Or are you expecting that this will be used through the Haskell IDE? |
@ndmitchell it works using our Edit to add: Here's a snippet of our
|
Sorry I let this sit for so long. Thank y'all. |
@ndmitchell anything we can do to get this ready to merge? |
Closes #1434