Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(resharding) - Stabilize Resharding V3 #12792

Merged
merged 14 commits into from
Jan 24, 2025
Merged

feat(resharding) - Stabilize Resharding V3 #12792

merged 14 commits into from
Jan 24, 2025

Conversation

wacban
Copy link
Contributor

@wacban wacban commented Jan 24, 2025

Feature to stabilize

This PR stabilizes Resharding V3. It introduces a new implementation for resharding and two new shard layouts for the production networks.

Context

Testing and QA

This feature was extensively tested in unit tests, testloop tests and in forknet.

Checklist

@wacban wacban force-pushed the waclaw-resharding branch from 5758794 to 7756e89 Compare January 24, 2025 11:15
@wacban wacban force-pushed the waclaw-resharding branch from bf7a047 to b6e4100 Compare January 24, 2025 11:19
@wacban wacban marked this pull request as ready for review January 24, 2025 13:59
@wacban wacban requested a review from a team as a code owner January 24, 2025 13:59
Copy link
Contributor

@shreyan-gupta shreyan-gupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@Trisfald Trisfald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many more changes than I expected, but it looks good!

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 92.52336% with 8 lines in your changes missing coverage. Please review.

Project coverage is 70.51%. Comparing base (5b32984) to head (a109857).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
core/primitives/src/epoch_manager.rs 56.25% 7 Missing ⚠️
chain/epoch-manager/src/lib.rs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12792      +/-   ##
==========================================
- Coverage   70.53%   70.51%   -0.02%     
==========================================
  Files         846      846              
  Lines      174904   175018     +114     
  Branches   174904   175018     +114     
==========================================
+ Hits       123372   123418      +46     
- Misses      46282    46347      +65     
- Partials     5250     5253       +3     
Flag Coverage Δ
backward-compatibility 0.16% <0.00%> (+<0.01%) ⬆️
db-migration 0.16% <0.00%> (+<0.01%) ⬆️
genesis-check 1.40% <5.88%> (+0.05%) ⬆️
linux 70.10% <92.52%> (+0.93%) ⬆️
linux-nightly 70.12% <92.52%> (-0.02%) ⬇️
pytests 1.70% <5.88%> (+0.05%) ⬆️
sanity-checks 1.51% <5.88%> (+0.05%) ⬆️
unittests 70.35% <92.52%> (-0.02%) ⬇️
upgradability 0.20% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wacban wacban added this pull request to the merge queue Jan 24, 2025
@wacban
Copy link
Contributor Author

wacban commented Jan 24, 2025

Many more changes than I expected, but it looks good!

Yeah those PRs are quite annoying. The tests broken due to double resharding were an extra hurdle but luckily not too bad.

Merged via the queue into master with commit 09022ca Jan 24, 2025
29 checks passed
@wacban wacban deleted the waclaw-resharding branch January 24, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants