-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(resharding) - Stabilize Resharding V3 #12792
Conversation
5758794
to
7756e89
Compare
bf7a047
to
b6e4100
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many more changes than I expected, but it looks good!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12792 +/- ##
==========================================
- Coverage 70.53% 70.51% -0.02%
==========================================
Files 846 846
Lines 174904 175018 +114
Branches 174904 175018 +114
==========================================
+ Hits 123372 123418 +46
- Misses 46282 46347 +65
- Partials 5250 5253 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Yeah those PRs are quite annoying. The tests broken due to double resharding were an extra hurdle but luckily not too bad. |
Feature to stabilize
This PR stabilizes Resharding V3. It introduces a new implementation for resharding and two new shard layouts for the production networks.
Context
Testing and QA
This feature was extensively tested in unit tests, testloop tests and in forknet.
Checklist
Unreleased
section.