test: more global contract integration tests #12965
Open
+359
−148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pugachAG
force-pushed
the
global-contracts-test-loop
branch
2 times, most recently
from
6b85e66 to
bfbeb61
Compare
pugachAG
changed the title
pugachAG
changed the title
pugachAG
force-pushed
the
global-contracts-test-loop
branch
from
bfbeb61 to
2402d30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves introduces dedicated test loop mod for global contract moving
test_global_contract_by_hashandtest_global_contract_by_account_idthere. More checks are added as part of those tests and 2 more tests are introduced. All details are hidden inside ofGlobalContractsTestEnvso tests operate on high-level concepts making it easier to understand.Note that I explicitly opted out from using
build_genesis_and_epoch_config_storebecause I don't think it provides a good API. I plan introducing an alternative in a separate PR.Part of #12718.