-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support for react 19 and next15 #2731
base: master
Are you sure you want to change the base?
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit da016a5:
|
packages/react-native-web/src/vendor/react-native/VirtualizedList/index.js
Outdated
Show resolved
Hide resolved
This PR looks surprisingly straightforward to me. (Great work!) Do we think it's feature-complete? I'm unfamiliar with next15 and if there's more work to be done here, but it'd be great to be React-19-ready. |
I believe it's feature-complete. We updated our production website to Next.js v15 + React 19 with this and so far it's been working well. cc @necolas One caveat is that I had to make // our workaround
const findNodeHandle = (component) => {
throw new Error(
'findNodeHandle has been removed in React 19. ' +
'Use the ref property on the component instead.'
);
}; I suggest trying out this PR and report any issues you encounter to get this merged. |
Looking forward to seeing this be merged in! |
Please let us know if this needs any changes or details/description before you decide to merge. The person who raised the PR is also a part of our team, hence we will do the changes if required. |
Apart from the linting, prettier changes that @FezVrasta reviewed, Are there any other changes that needs addressing? |
ping @necolas |
@sacru2red, I would suggest you should use |
ah... I've seen necolas often commit to |
@necolas would you mind sharing your thoughts? If react-native-web is to be deprecated in favor of react-strict-dom or expo it would be incredibly timely to learn this now rather than later as my startup is just starting to build things out! (I specifically didn’t go with expo, as I appreciate your approach and the core) |
Thanks @Viraj-10. Admittedly that discussion leaves me more stuck than expected. Oof. |
Changelog
unmountComponentAtNode
withroot.unmount
.hydrate
andrender
.findDOMNode
.