Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export numG and qSize #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

guilhem
Copy link
Contributor

@guilhem guilhem commented Jun 22, 2021

This permit to create a group without using WithContext.
As cancel is nil, errgroup will not send a context close at first error.

This permit to create a group without using `WithContext`.
As cancel is nil, errgroup will not send a context close at first error.
@neilotoole
Copy link
Owner

@guilhem Apologies for the egregious delay in responding to you. Thank you for the PR.

One of the reasons that numG and qSize are unexported is because we don't want those field values to change during the lifetime of the Group... or at a minimum, updating those fields should be done atomically.

As cancel is nil, errgroup will not send a context close at first error.

Is this not desirable?

This permit to create a group without using WithContext.

Can you elaborate some more on the issue you're facing that this PR resolves? Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants