Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major content update; should qualify for a 1.4.0 release #17

Merged
merged 11 commits into from
Oct 6, 2021

Conversation

cooljeanius
Copy link
Collaborator

@cooljeanius cooljeanius commented Aug 24, 2021

See CHANGELOG.cfg and README_egallager_mods.txt for details.
This addresses issue #5 (somewhat) and issue #7 (partially; it's almost done), makes the situation for issue #10 worse (since I updated the potfile again), addresses some of the points in issue #15, and fixes issue #16. I am marking this as a draft because I introduced a new bug that I couldn't figure out how to fix, and I'd want to get it fixed properly before merging: specifically, it's the one about modifications made in Scenario 17 persisting after they're supposed to have ended. Once that is fixed, this can be merged, and a new 1.4.0 release can be made.

see CHANGELOG.cfg and README_egallager_mods.txt for details
@cooljeanius
Copy link
Collaborator Author

This ought to be the equivalent comparison in my primary version of this repo: https://github.com/cooljeanius/A_New_Order/compare/b50254d4088aa5f23fc4d0482d6a9292c30b7719..1f6c6bb190b70220984e30e5e2e3832e8454463a

@cooljeanius
Copy link
Collaborator Author

ok so ef09f42 should have fixed the bug with modifications persisting too long, so I'm taking this out of draft mode and marking it as ready for review

@cooljeanius cooljeanius marked this pull request as ready for review August 29, 2021 06:07
@cooljeanius
Copy link
Collaborator Author

@knyghtmare would probably be interested to know that I buffed the Akladian healers in this for the player's side

@cooljeanius
Copy link
Collaborator Author

cooljeanius commented Sep 27, 2021

@nemaara I'd appreciate it if you could get this reviewed and merged before Wesnoth 1.16 releases; I'd like to get one more release of ANO onto the 1.14 add-on server while it's still the latest stable version
Edit: nvm; after discussion on Discord we're going to wait

use {HIGHLIGHT_IMAGE} for Battle of Barnon; dup of cooljeanius/A_New_Order@db7af32
@cooljeanius
Copy link
Collaborator Author

@Asheviere said she might be giving this a playthru soon

make a bit harder on harder difficulties, based on feedback from @Asheviere, to try to make the following scenario harder; dup of cooljeanius/A_New_Order@b4b651f
- minor commentary additions
- sync changes from S19b back to S19a
- regenerate potfile with wmlxgettext

dup of cooljeanius/A_New_Order@42d1527
@nemaara nemaara merged commit 3b71676 into nemaara:master Oct 6, 2021
@cooljeanius cooljeanius deleted the egallager-1.4.0 branch October 6, 2021 04:40
@cooljeanius
Copy link
Collaborator Author

Thanks for merging! Time for a new tag for a new release?

@nemaara
Copy link
Owner

nemaara commented Oct 6, 2021

I don't usually use tags and such but I'm gonna upload it once I get the chance. Do you have any idea if this works on 1.16? Otherwise we'll have to do a playthrough to catch bugs.

@cooljeanius
Copy link
Collaborator Author

I haven't tried it on 1.16 yet; I think a separate release for porting to the 1.16 server would be necessary. And having a tag would be helpful to point/link people to, in order to let people know that there's been a new release. And you did do a tag for the previous release: https://github.com/nemaara/A_New_Order/releases/tag/1.3.0

@nemaara
Copy link
Owner

nemaara commented Oct 6, 2021

Okay sure I'll tag it. Yeah, we'll need a separate one for 1.16 then.

@cooljeanius
Copy link
Collaborator Author

cooljeanius commented Oct 7, 2021

Okay sure I'll tag it. Yeah, we'll need a separate one for 1.16 then.

@nemaara Post the link to the tag here once it's live so I can share it please! Thanks.

cooljeanius added a commit that referenced this pull request Aug 25, 2024
…esnoth-map-diff-95b3973

Bump utils/wesnoth-map-diff from `9159e4e` to `95b3973`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants