test: output of all files #259
nenikitovtest.yml
on: pull_request
ubuntu / nightly / direct-minimal-versions
28s
Matrix: os-check
Matrix: required
Annotations
5 warnings
|
unnecessary semicolon:
ashen/src/utils/nom.rs#L119
warning: unnecessary semicolon
--> ashen/src/utils/nom.rs:119:14
|
119 | };
| ^ help: remove
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_semicolon
|
|
unnecessary semicolon:
ashen/src/error.rs#L119
warning: unnecessary semicolon
--> ashen/src/error.rs:119:6
|
119 | };
| ^ help: remove
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_semicolon
= note: `#[warn(clippy::unnecessary_semicolon)]` implied by `#[warn(clippy::pedantic)]`
|
|
this `map_or` can be simplified:
ashen/src/asset/sound/dat/mixer.rs#L212
warning: this `map_or` can be simplified
--> ashen/src/asset/sound/dat/mixer.rs:212:20
|
212 | || envelope
| ____________________^
213 | | .sustain
214 | | .map_or(true, |s| self.pos_volume_envelope < s))
| |___________________________________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
= note: `#[warn(clippy::unnecessary_map_or)]` on by default
help: use is_none_or instead
|
214 - .map_or(true, |s| self.pos_volume_envelope < s))
214 + .is_none_or(|s| self.pos_volume_envelope < s))
|
|
|
docs for function returning `Result` missing `# Errors` section:
ashen/src/asset/pack_file.rs#L26
warning: docs for function returning `Result` missing `# Errors` section
--> ashen/src/asset/pack_file.rs:26:5
|
26 | pub fn new(input: &[u8]) -> Result<Self> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
= note: `#[warn(clippy::missing_errors_doc)]` implied by `#[warn(clippy::pedantic)]`
|
|
docs for function which may panic missing `# Panics` section:
ashen/src/asset/color_map.rs#L18
warning: docs for function which may panic missing `# Panics` section
--> ashen/src/asset/color_map.rs:18:5
|
18 | pub fn from_12_bit(color: u16) -> Self {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: first possible panic found here
--> ashen/src/asset/color_map.rs:20:9
|
20 | assert!(color <= 0xFFF, "12 bit color is smaller than 0xFFF");
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
note: the lint level is defined here
--> ashen/src/lib.rs:1:9
|
1 | #![warn(clippy::pedantic)]
| ^^^^^^^^^^^^^^^^
= note: `#[warn(clippy::missing_panics_doc)]` implied by `#[warn(clippy::pedantic)]`
|