Implement NotaryAssisted transaction attribute #3175

AnnaShaleva · 2024-03-06T09:00:44Z

Description

Close #2896. Use a stub for native Notary contract hash since this contract is not implemented yet. Thus, technically, NotaryAssisted attribute verification will always fail on real network until native Notary is implemented.

Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

A group of unit tests for NotaryAssisted attribute.

Checklist:

Close neo-project#2896. Use a stub for native Notary contract hash since this contract is not implemented yet. Thus, technically, NotaryAssisted attribute verification will always fail on real network until native Notary is implemented. Signed-off-by: Anna Shaleva <[email protected]>

Port neo-project/neo#3175. Ref. neo-project/neo#2896. Signed-off-by: Anna Shaleva <[email protected]>

AnnaShaleva · 2024-03-06T12:08:22Z

I'm not allowed to request review, set labels or resolve conversations. Maybe someone from neo-project with access rights can allow me at least to request review?

shargon · 2024-03-06T13:26:12Z

I'm not allowed to request review, set labels or resolve conversations. Maybe someone from neo-project with access rights can allow me at least to request review?

You didn't accept your role xD, I sent you an invitation time ago... Time to review your email? 😄

src/Neo/SmartContract/Native/PolicyContract.cs

Jim8y · 2024-03-06T13:35:55Z

Hi @AnnaShaleva , we are trying to add as much comments in the core as possible, may you please add comments to explain CalculateNetworkFee.

src/Neo/SmartContract/Native/PolicyContract.cs

…ribute Signed-off-by: Anna Shaleva <[email protected]>

AnnaShaleva · 2024-03-06T15:12:08Z

may you please add comments to explain CalculateNetworkFee.

Sure, fixed.

roman-khimov

GAS.OnPersist change is missing for the attribute.

src/Neo/Network/P2P/Payloads/TransactionAttributeType.cs

src/Neo/Network/P2P/Payloads/NotaryAssisted.cs

Transactions network fee should be split between Primary node and Notary nodes. Signed-off-by: Anna Shaleva <[email protected]>

Signed-off-by: Anna Shaleva <[email protected]>

Once Notary contract is implemented, this hash will be replaced by a proper Notary contract hash. The exact value won't be changed since Notary contract has constant hash as any other native contract. Signed-off-by: Anna Shaleva <[email protected]>

AnnaShaleva · 2024-03-07T09:40:52Z

GAS.OnPersist change is missing for the attribute.

Completely forgot about it, fixed.

vncoelho · 2024-03-07T09:42:10Z

Maybe this PR we merge after next release.

AnnaShaleva · 2024-03-07T09:45:17Z

Maybe this PR we merge after next release.

This PR doesn't hurt because currently in real network NotaryAssisted attribute is always invalid since transaction must have Notary contract as a signer, and Notary contract is not implemented yet.

Thus, I vote to merge it before 3.7. What do you think?

roman-khimov · 2024-03-07T10:13:25Z

It goes step by step, @vncoelho. What this delay would buy us? The attribute logic is rather simple on its own.

shargon

I need more time to review the notary proposal, honestly, I didn't expect it to be merged in 3.7 and it is already beginning to produce changes in the core

src/Neo/SmartContract/Native/GasToken.cs

Signed-off-by: Anna Shaleva <[email protected]>

Related to additional storage entries added by the previous changes. Signed-off-by: Anna Shaleva <[email protected]>

shargon · 2025-01-23T14:07:36Z

src/Neo/SmartContract/Native/GasToken.cs

+                var notaryAssisted = tx.GetAttribute<NotaryAssisted>();
+                if (notaryAssisted is not null)
+                {
+                    totalNetworkFee -= (notaryAssisted.NKeys + 1) * Policy.GetAttributeFee(engine.SnapshotCache, (byte)notaryAssisted.Type);


@AnnaShaleva AttributeFee in memory pool can be 1, and during the block persistence can be changed to 2, this could underflow totalNetworkFee and produce a denial of service.

Can't happen. It's OnPersist and it's executed before any in-block transaction, the value is the same as was used when verifying the transaction.

BTW, it's pretty similar to tx.Sender having enough GAS on his account to pay for tx.SystemFee + tx.NetworkFee, same guarantee level.

@shargon, do you still have any concern about this issue?

I'm agree with @roman-khimov, it will be the same as other attributes, and other fees, but i'm not sure if this is the best way to recollect fees, why not deposit the Gas in the contract as a fee during the execution of the contract (like a regular contract can do)?

src/Neo/SmartContract/Native/PolicyContract.cs

Signed-off-by: Anna Shaleva <[email protected]>

shargon · 2025-02-18T10:06:02Z

src/Neo/SmartContract/Native/GasToken.cs

+                var notaryAssisted = tx.GetAttribute<NotaryAssisted>();
+                if (notaryAssisted is not null)
+                {
+                    totalNetworkFee -= (notaryAssisted.NKeys + 1) * Policy.GetAttributeFee(engine, (byte)notaryAssisted.Type);


I'm agree with @roman-khimov, it will be the same as other attributes, and other fees, but i'm not sure if this is the best way to recollect fees, why not deposit the Gas in the contract as a fee during the execution of the contract (like a regular contract can do)?

You mean deducting this GAS from the user's balance in Notary? This doesn't work in a scenario when third party pays for execution or any other when user is not even signing (as in being a proper signer) the main transaction. Our FS chain transactions are routinely created with the following set of signers:

proxy contract (holding a lot of GAS)

alphabet (~validators) multisig

(optionally) SN key

Transactions generated by IR have two signers, transactions generated by SNs can have three. Either way Proxy contract pays for execution and that's one of the core features for us (hi, #2577), if that wasn't the case we'd have a lot of problems with GAS distribution and spending between all parties (IR/SN). We do have some distribution still, but mostly that's just moving all GAS to proxy because normally IR and SN shouldn't spend any GAS at all from their accounts. Once they've deposited some to the Notary contract and if they're sending correct transactions (IR checks them before approval of course) everything is paid for by the Proxy contract.

So we want to get this fee from the network fee and not some notary account, it's not possible in some cases. We also have a concept of paid attributes now and this just redistributes this attribute fee in a bit more specific manner.

src/Neo/SmartContract/Native/PolicyContract.cs

* EC Recover * Clean code * Fix ut * Fix ut * Unify hashing * Allow HashAlgorithm.None * Clean comment * Update src/Neo/Cryptography/Crypto.cs * Fix merge * Add None check * Fix GetHash * fix unit testing issues * Clean code * Update src/Neo/SmartContract/Native/CryptoLib.cs --------- Co-authored-by: Jimmy <[email protected]>

* tests: add UT for nested WitnessCondition This just works as the code works. Signed-off-by: Roman Khimov <[email protected]> * WitnessCondition: unify nesting checks, fix MaxNestingDepth 1. We have some duplication around "maxNestDepth <= 0" checks. 2. If we're to fix them by moving to DeserializeFrom() and thereby affecting all types of conditions we can discover a simple truth about conditions that was hidden previously: our real supported MaxNestingDepth is 3, not 2. 3. Test_WitnessCondition_Nesting works as before, check it there, we have And->And->Boolean and other nesting cases, 3-4 elements in the chain, not 2. Signed-off-by: Roman Khimov <[email protected]> * WitnessCondition: unify JSON parsing as well Signed-off-by: Roman Khimov <[email protected]> * tests: s/WitnessContition/WitnessCondition/ Fix typo. Signed-off-by: Roman Khimov <[email protected]> * Format header * Format arrays in UT_WitnessCondition.cs --------- Signed-off-by: Roman Khimov <[email protected]> Co-authored-by: Shargon <[email protected]> Co-authored-by: Christopher Schuchardt <[email protected]> Co-authored-by: NGD Admin <[email protected]>

@shargon

* Add Support for plugin loading * Added @shargon request of changes --------- Co-authored-by: Shargon <[email protected]> Co-authored-by: NGD Admin <[email protected]>

@cschuchardt88

* Optimize key builder * Optimize with GetSpan * Use Span * Clean * Rename * Update src/Neo/SmartContract/KeyBuilder.cs Co-authored-by: nan01ab <[email protected]> * Update KeyBuilder.cs * @cschuchardt88 feedback * Avoid ToArray in StorageKey constructor * Use sizeof * Optimize ECPoint * Optimize ECPoint * Add ISerializableSpan * Move to StorageKey * Use ReadOnlySpan --------- Co-authored-by: nan01ab <[email protected]> Co-authored-by: Christopher Schuchardt <[email protected]>

* Add some stuff to hope once and for all fix the linux workflows * update workflow * update nuget.yml * Change dig to detailed, log too big * Fix targets * revert main.yml * Update .github/workflows/main.yml * disable BuildInParallel --------- Co-authored-by: Jimmy <[email protected]> Co-authored-by: Shargon <[email protected]>

AnnaShaleva added a commit to AnnaShaleva/neo-devpack-dotnet that referenced this pull request Mar 6, 2024

Add NotaryAssisted transaction attribute type

24c6641

Port neo-project/neo#3175. Ref. neo-project/neo#2896. Signed-off-by: Anna Shaleva <[email protected]>

AnnaShaleva mentioned this pull request Mar 6, 2024

Add NotaryAssisted transaction attribute type neo-project/neo-devpack-dotnet#983

Open

AnnaShaleva added a commit to AnnaShaleva/neo-modules that referenced this pull request Mar 6, 2024

Add NotaryAssisted transaction attribute type

8f55314

Port neo-project/neo#3175. Ref. neo-project/neo#2896. Signed-off-by: Anna Shaleva <[email protected]>

AnnaShaleva mentioned this pull request Mar 6, 2024

Add NotaryAssisted transaction attribute type neo-project/neo-modules#884

Closed

roman-khimov requested review from shargon, Jim8y and roman-khimov March 6, 2024 12:34

shargon reviewed Mar 6, 2024

View reviewed changes

src/Neo/SmartContract/Native/PolicyContract.cs Outdated Show resolved Hide resolved

Jim8y reviewed Mar 6, 2024

View reviewed changes

src/Neo/SmartContract/Native/PolicyContract.cs Show resolved Hide resolved

Payloads: add doc to CalculateNetworkFee method of NotaryAssisted att…

acec1b0

…ribute Signed-off-by: Anna Shaleva <[email protected]>

AnnaShaleva requested review from shargon and Jim8y March 6, 2024 15:12

roman-khimov requested changes Mar 6, 2024

View reviewed changes

src/Neo/Network/P2P/Payloads/TransactionAttributeType.cs Outdated Show resolved Hide resolved

roman-khimov reviewed Mar 7, 2024

View reviewed changes

src/Neo/Network/P2P/Payloads/NotaryAssisted.cs Outdated Show resolved Hide resolved

AnnaShaleva added 3 commits March 7, 2024 12:27

Native: add NotaryAssisted attributes handler to Gas OnPersist

1508d4f

Transactions network fee should be split between Primary node and Notary nodes. Signed-off-by: Anna Shaleva <[email protected]>

Payloads: adjust comment to NotaryAssisted attribute

8b547c9

Signed-off-by: Anna Shaleva <[email protected]>

AnnaShaleva requested a review from roman-khimov March 7, 2024 09:41

roman-khimov previously approved these changes Mar 7, 2024

View reviewed changes

shargon reviewed Mar 8, 2024

View reviewed changes

Merge branch 'master' into notary-assisted

00b54ff

Merge branch 'master' into notary-assisted

4af93c8

AnnaShaleva dismissed cschuchardt88’s stale review via 4af93c8 January 23, 2025 13:47

shargon reviewed Jan 23, 2025

View reviewed changes

src/Neo/SmartContract/Native/GasToken.cs Outdated Show resolved Hide resolved

SmartContract: refactor obsolete code

ec4e3d6

Signed-off-by: Anna Shaleva <[email protected]>

AnnaShaleva force-pushed the notary-assisted branch from ae6ad54 to ec4e3d6 Compare January 23, 2025 13:59

AnnaShaleva and others added 2 commits January 23, 2025 17:00

Persistance: fix UT

bf4b294

Related to additional storage entries added by the previous changes. Signed-off-by: Anna Shaleva <[email protected]>

Clean comments

d5f37df

shargon reviewed Jan 23, 2025

View reviewed changes

src/Neo/SmartContract/Native/PolicyContract.cs Show resolved Hide resolved

nan01ab reviewed Jan 23, 2025

View reviewed changes

src/Neo/SmartContract/Native/PolicyContract.cs Outdated Show resolved Hide resolved

src/Neo/SmartContract/Native/PolicyContract.cs Outdated Show resolved Hide resolved

AnnaShaleva added 2 commits February 16, 2025 20:17

Merge branch 'master' into notary-assisted

fb35cec

Native: improve exception message for Policy's getFee/setFee

5648a9b

Signed-off-by: Anna Shaleva <[email protected]>

AnnaShaleva requested review from shargon and nan01ab February 16, 2025 17:23

shargon reviewed Feb 18, 2025

View reviewed changes

src/Neo/SmartContract/Native/PolicyContract.cs Outdated Show resolved Hide resolved

AnnaShaleva commented Feb 18, 2025

View reviewed changes

src/Neo/SmartContract/Native/PolicyContract.cs Show resolved Hide resolved

shargon and others added 6 commits February 19, 2025 20:20

Add Support for Plugin Loading by Assembly (neo-project#3755)

f73364d

* Add Support for plugin loading * Added @shargon request of changes --------- Co-authored-by: Shargon <[email protected]> Co-authored-by: NGD Admin <[email protected]>

Update src/Neo/SmartContract/Native/PolicyContract.cs

8af28d1

AnnaShaleva force-pushed the notary-assisted branch from 342a051 to 8af28d1 Compare February 19, 2025 17:22

AnnaShaleva requested review from shargon and cschuchardt88 February 19, 2025 17:25

Merge branch 'master' into notary-assisted

2544d26

shargon approved these changes Feb 22, 2025

View reviewed changes

Merge branch 'master' into notary-assisted

0785c0f

nan01ab approved these changes Feb 22, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement NotaryAssisted transaction attribute #3175

Implement NotaryAssisted transaction attribute #3175

AnnaShaleva commented Mar 6, 2024 •

edited

Loading

AnnaShaleva commented Mar 6, 2024

shargon commented Mar 6, 2024

Jim8y commented Mar 6, 2024

AnnaShaleva commented Mar 6, 2024

roman-khimov left a comment

AnnaShaleva commented Mar 7, 2024

vncoelho commented Mar 7, 2024

AnnaShaleva commented Mar 7, 2024

roman-khimov commented Mar 7, 2024

shargon left a comment

shargon Jan 23, 2025

roman-khimov Feb 13, 2025

roman-khimov Feb 13, 2025

AnnaShaleva Feb 16, 2025

shargon Feb 18, 2025

shargon Feb 18, 2025

roman-khimov Feb 18, 2025

Implement NotaryAssisted transaction attribute #3175

Are you sure you want to change the base?

Implement NotaryAssisted transaction attribute #3175

Conversation

AnnaShaleva commented Mar 6, 2024 • edited Loading

Description

Type of change

How Has This Been Tested?

Checklist:

AnnaShaleva commented Mar 6, 2024

shargon commented Mar 6, 2024

Jim8y commented Mar 6, 2024

AnnaShaleva commented Mar 6, 2024

roman-khimov left a comment

Choose a reason for hiding this comment

AnnaShaleva commented Mar 7, 2024

vncoelho commented Mar 7, 2024

AnnaShaleva commented Mar 7, 2024

roman-khimov commented Mar 7, 2024

shargon left a comment

Choose a reason for hiding this comment

shargon Jan 23, 2025

Choose a reason for hiding this comment

roman-khimov Feb 13, 2025

Choose a reason for hiding this comment

roman-khimov Feb 13, 2025

Choose a reason for hiding this comment

AnnaShaleva Feb 16, 2025

Choose a reason for hiding this comment

shargon Feb 18, 2025

Choose a reason for hiding this comment

shargon Feb 18, 2025

Choose a reason for hiding this comment

roman-khimov Feb 18, 2025

Choose a reason for hiding this comment

AnnaShaleva commented Mar 6, 2024 •

edited

Loading