Updated KeyBuilder Fast Access

[cschuchardt88]

Description

Fixed with Disposing MemoryStream on ToArray(). Made a lot faster as well. Enforced Overflows and other lengths.

Type of change

• Optimization (the change is only an optimization)
• Style (the change is only a code style for better maintenance or standard purpose)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

• Unit Testing

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[nan01ab]

Any benchmark data?

[shargon]

Increase it?

[cschuchardt88]

why? Is not >= or what do you mean

[shargon]

I mean, increase the array instead of throw an error

[cschuchardt88]

Since the Length is passed in, we need to enforce that length. 99% of the time we know the length up front?

[shargon]

Otherwise is not a hint, and is not working as before, it should not happen so it won't have any impact in the performance

[cschuchardt88]

I had @superboyiii test this on mainnet and testnet, no key is bigger than 64 bytes. So we need to enforce. If you want bigger key you must know the size before hand.

#3705 (review)

[shargon]

It haven't got any sense to me, throw an exception when is possible to increase the buffer, usability vs optimization? Could you clarify why we should not increase the buffer and preserve the previous behavior?

[cschuchardt88]

I already did state that. You pass in a LENGTH. What's the point of doing that if it not enforced? Im sick of everything being programmed around these bugs. It needs to stop. Have some discipline.

[Jim8y]

I will add some benchmark for this pr, wait few a while.

[Jim8y]

BenchmarkDotNet v0.14.0, macOS Sonoma 14.6.1 (23G93) [Darwin 23.6.0]
Apple M1 Pro, 1 CPU, 10 logical and 10 physical cores
.NET SDK 9.0.102
[Host] : .NET 9.0.1 (9.0.124.61010), Arm64 RyuJIT AdvSIMD
DefaultJob : .NET 9.0.1 (9.0.124.61010), Arm64 RyuJIT AdvSIMD

Before this pr

Method	DataSize	Mean	Error	StdDev	Ratio	RatioSD	Gen0	Allocated	Alloc Ratio
KeyBuilder_AddByteArray	8	44.63 ns	0.943 ns	1.158 ns	1.00	0.04	0.0268	168 B	1.00
KeyBuilder_AddReadOnlySpan	8	44.18 ns	0.326 ns	0.272 ns	0.99	0.03	0.0268	168 B	1.00
KeyBuilder_AddSerializableSpan	8	34.30 ns	0.121 ns	0.107 ns	0.77	0.02	0.0268	168 B	1.00
KeyBuilder_AddByteArray	32	44.79 ns	0.308 ns	0.288 ns	1.00	0.01	0.0293	184 B	1.00
KeyBuilder_AddReadOnlySpan	32	43.70 ns	0.199 ns	0.177 ns	0.98	0.01	0.0293	184 B	1.00
KeyBuilder_AddSerializableSpan	32	43.42 ns	0.252 ns	0.224 ns	0.97	0.01	0.0293	184 B	1.00
KeyBuilder_AddByteArray	128	45.27 ns	0.107 ns	0.095 ns	1.00	0.00	0.0344	216 B	1.00
KeyBuilder_AddReadOnlySpan	128	46.20 ns	0.067 ns	0.056 ns	1.02	0.00	0.0344	216 B	1.00
KeyBuilder_AddSerializableSpan	128	45.83 ns	0.070 ns	0.066 ns	1.01	0.00	0.0344	216 B	1.00

After this pr

Method	DataSize	Mean	Error	StdDev	Median	Ratio	RatioSD	Gen0	Allocated	Alloc Ratio
KeyBuilder_AddByteArray	8	21.47 ns	0.031 ns	0.024 ns	21.47 ns	1.00	0.00	0.0204	128 B	1.00
KeyBuilder_AddReadOnlySpan	8	26.38 ns	0.566 ns	1.429 ns	26.83 ns	1.23	0.07	0.0204	128 B	1.00
KeyBuilder_AddSerializableSpan	8	27.09 ns	0.225 ns	0.199 ns	27.06 ns	1.26	0.01	0.0204	128 B	1.00
KeyBuilder_AddByteArray	32	26.18 ns	0.077 ns	0.072 ns	26.20 ns	1.00	0.00	0.0229	144 B	1.00
KeyBuilder_AddReadOnlySpan	32	26.66 ns	0.063 ns	0.059 ns	26.68 ns	1.02	0.00	0.0229	144 B	1.00
KeyBuilder_AddSerializableSpan	32	27.84 ns	0.062 ns	0.058 ns	27.83 ns	1.06	0.00	0.0229	144 B	1.00
KeyBuilder_AddByteArray	128	27.91 ns	0.039 ns	0.037 ns	27.91 ns	1.00	0.00	0.0280	176 B	1.00
KeyBuilder_AddReadOnlySpan	128	28.68 ns	0.058 ns	0.049 ns	28.69 ns	1.03	0.00	0.0280	176 B	1.00
KeyBuilder_AddSerializableSpan	128	29.44 ns	0.042 ns	0.037 ns	29.44 ns	1.05	0.00	0.0280	176 B	1.00