[DRAFT]: streamlining of driver #210
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting stuff. So you have now two big PR (#199) ..I think it won't be easy to combine them. |
|
Indeed, I just pushed this for reference, Nabeel wanted to see it. I'll clean it up a bit during the day and we'll go from there.
Sent from Proton Mail Android
…-------- Original Message --------
On 03/07/2024 12:30, Michal Štefaňák wrote:
Interesting stuff. So you have now two big PR ([#199](#199)) ..I think it won't be easy to combine them.
—
Reply to this email directly, [view it on GitHub](#210 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AD5MVWRHTSTILLSAG2EVS3TZKOEBHAVCNFSM6AAAAABKIYDDEGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBVGEZTANRYG4).
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR tries to simplify typings, remove deprecations and extract the HTTP driver completely.