Skip to content

Add new GQLSTATUS codes for search #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Lojjs wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Add new GQLSTATUS codes for search #408

Lojjs wants to merge 4 commits into from

Conversation

@Lojjs
Copy link
Contributor

@Lojjs Lojjs commented Nov 10, 2025 •
edited by renetapopova
Loading

Lojjs
Lojjs commented Nov 10, 2025
View reviewed changes
@Lojjs Lojjs force-pushed the gqlstatus-for-search branch 2 times, most recently from 4be53df to 684abfb Compare November 10, 2025 12:16
@Lojjs Lojjs marked this pull request as ready for review November 10, 2025 12:17
@Lojjs Lojjs requested a review from renetapopova November 12, 2025 10:36
@Lojjs Lojjs added the dev The default branch. label Nov 12, 2025
Lojjs
Lojjs commented Nov 12, 2025
View reviewed changes
loveleif
loveleif approved these changes Nov 18, 2025
View reviewed changes
modules/ROOT/pages/errors/gql-errors/42I69.adoc Outdated
@@ -0,0 +1,38 @@
// TODO update to actual version when feature flag in enabled
:page-role: new-2026.01
Copy link
Contributor

@loveleif loveleif Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is available in 2026.01 do we need to hold the merge until then?

Copy link
Collaborator

@renetapopova renetapopova Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we should not merge it until then.

Copy link
Collaborator

@renetapopova renetapopova Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we decided not to label them.

Copy link
Contributor Author

@Lojjs Lojjs Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I wanted to make this PR while I had everything fresh in mind and to get feedback on the error and notification text, but we will not be able to merge it for quite a while. It is not decided when it will be released yet but 2026.01 is my best bet.

Right @renetapopova , I created this PR before our last meeting, I will remove the labels.

Copy link
Collaborator

@renetapopova renetapopova Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lojjs, I think we can merge this one after we merge https://github.com/neo-technology/neo4j/pull/34110.

@renetapopova renetapopova added 2026.01 and removed 2025.11 dev The default branch. labels Nov 18, 2025
@renetapopova renetapopova self-assigned this Nov 18, 2025
@neo4j-docops-agent
Copy link
Collaborator

neo4j-docops-agent commented Dec 11, 2025

This PR includes documentation updates
View the updated docs at https://neo4j-docs-status-codes-408.surge.sh

New pages:

Updated pages:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@renetapopova renetapopova renetapopova approved these changes

@loveleif loveleif loveleif approved these changes

Assignees

@loveleif loveleif

@renetapopova renetapopova

Labels

2026.01

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Lojjs @neo4j-docops-agent @loveleif @renetapopova