Skip GL state manipulation in ItemDecoratorHandler when there are no decorators

[embeddedt]

Alternative solution to #1482, that will accomplish the same goal (and is updated for 1.21.4). The GL state backup/restore is now skipped if there are no item decorators for an item. I did not profile this, as it's pretty obvious it cannot worsen performance.

[neoforged-pr-publishing]

• Publish PR to GitHub Packages

Last commit published: 59bf3cf312524abd8adfecd727af40092cfa5ecd.

PR Publishing

The artifacts published by this PR:

• 📦 net.neoforged:neoforge:21.4.5-beta-pr-1737-item-decorator-opt
• 📦 net.neoforged:testframework:21.4.5-beta-pr-1737-item-decorator-opt

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1737' // https://github.com/neoforged/NeoForge/pull/1737
        url 'https://prmaven.neoforged.net/NeoForge/pr1737'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1737.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1737
cd NeoForge-pr1737
curl -L https://prmaven.neoforged.net/NeoForge/pr1737/net/neoforged/neoforge/21.4.5-beta-pr-1737-item-decorator-opt/mdk-pr1737.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

[neoforged-releases]

🚀 This PR has been released as NeoForge version 21.4.6-beta.

[neoforged-automation]

Created backport PR: #1904