Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.21.1] Fix blur effect rendered at high z with depth test breaking subsequent rendering of screen elements #1741

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

XFactHD
Copy link
Member

@XFactHD XFactHD commented Dec 5, 2024

This PR fixes the blur effect breaking screen rendering when a lot of HUD layers are present and the blur effect is applied after drawing the dark half-transparent background.

Fixes #1504

@XFactHD XFactHD added bug A bug or error rendering Related to rendering regression Worked previously but doesn't anymore 1.21.1 Targeted at Minecraft 1.21.1 labels Dec 5, 2024
@XFactHD XFactHD requested a review from embeddedt December 5, 2024 01:54
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Dec 5, 2024

  • Publish PR to GitHub Packages

Last commit published: 8b59e9795ed285039bcb61dc85ea25d07d026cf1.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1741' // https://github.com/neoforged/NeoForge/pull/1741
        url 'https://prmaven.neoforged.net/NeoForge/pr1741'
        content {
            includeModule('net.neoforged', 'testframework')
            includeModule('net.neoforged', 'neoforge')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1741.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1741
cd NeoForge-pr1741
curl -L https://prmaven.neoforged.net/NeoForge/pr1741/net/neoforged/neoforge/21.1.86-pr-1741-blur_depth_test/mdk-pr1741.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

embeddedt
embeddedt previously approved these changes Dec 5, 2024
@embeddedt embeddedt merged commit 91b27b7 into neoforged:1.21.1 Dec 6, 2024
6 checks passed
@neoforged-releases
Copy link

🚀 This PR has been released as NeoForge version 21.1.84.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.1 Targeted at Minecraft 1.21.1 bug A bug or error regression Worked previously but doesn't anymore rendering Related to rendering
Projects
None yet
3 participants