Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom composite checkout action and fix builds #1893

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

Matyrobbrt
Copy link
Member

This PR fixes PR builds by replacing the duplicate code to check out the repository with a custom composite action that is patched to account for actions/checkout#2041 as the Git version on GitHub-hosted runners was updated to 2.48.1 a few hours ago.

@Matyrobbrt Matyrobbrt added ci/build Related to continuous integration/build system 1.21.4 Targeted at Minecraft 1.21.4 labels Jan 23, 2025
@neoforged-pr-publishing
Copy link

  • Publish PR to GitHub Packages

@marchermans marchermans merged commit e88c0df into neoforged:1.21.x Jan 23, 2025
5 checks passed
@Matyrobbrt Matyrobbrt deleted the fix-checkout branch January 23, 2025 14:42
@neoforged-releases
Copy link

🚀 This PR has been released as NeoForge version 21.4.73-beta.

@Matyrobbrt
Copy link
Member Author

@neoforged/bots backport 1.21.3

@neoforged-automation
Copy link

Backporting to 1.21.3...

@neoforged-automation
Copy link

@Matyrobbrt backport to 1.21.3 failed.

Click for failure reason

{"message":"Validation Failed","errors":[{"resource":"PullRequest","field":"head","code":"invalid"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}
https://github.com/neoforged/PRActionRunner/actions/runs/13000279133

@Matyrobbrt
Copy link
Member Author

@neoforged/bots backport 1.21.3

@neoforged-automation
Copy link

Backporting to 1.21.3...

@neoforged-automation
Copy link

@Matyrobbrt backport to 1.21.3 failed.

Click for failure reason

{"message":"Validation Failed","errors":[{"resource":"PullRequest","field":"head","code":"invalid"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}
https://github.com/neoforged/PRActionRunner/actions/runs/13000535466

@Matyrobbrt

This comment has been minimized.

neoforged-automation bot pushed a commit that referenced this pull request Jan 28, 2025
@neoforged-automation
Copy link

Created backport PR: #1926

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.4 Targeted at Minecraft 1.21.4 ci/build Related to continuous integration/build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants