Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix api name in comments of BlockBehavior #1909

Merged
merged 8 commits into from
Feb 6, 2025
Merged

Fix api name in comments of BlockBehavior #1909

merged 8 commits into from
Feb 6, 2025

Conversation

YocyCraft
Copy link
Contributor

Change from IForgeBlockState to IBlockStateExtension.

@neoforged-automation neoforged-automation bot added the 1.21.4 Targeted at Minecraft 1.21.4 label Jan 24, 2025
@CLAassistant
Copy link

CLAassistant commented Jan 24, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@neoforged-pr-publishing
Copy link

  • Publish PR to GitHub Packages

@YocyCraft YocyCraft changed the title Fix api name in comments of net.minecraft.world.level.block.state.BlockBehavior Fix api name in comments of BlockBehavior Jan 24, 2025
ChampionAsh5357
ChampionAsh5357 requested changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@ChampionAsh5357 ChampionAsh5357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last of the inconsistencies, thanks!

patches/net/minecraft/world/level/block/state/BlockBehaviour.java.patch Outdated Show resolved Hide resolved
patches/net/minecraft/world/level/block/state/BlockBehaviour.java.patch Outdated Show resolved Hide resolved
ChampionAsh5357
ChampionAsh5357 requested changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@ChampionAsh5357 ChampionAsh5357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final checks because I realized the clone item stack has a weirdly different signature.

patches/net/minecraft/world/level/block/state/BlockBehaviour.java.patch Outdated Show resolved Hide resolved
@YocyCraft @ChampionAsh5357
Update signature in comment
fffb368 
Co-authored-by: ChampionAsh5357 <[email protected]>
@YocyCraft @ChampionAsh5357
Fix signature in comment
94f6aa5 
Co-authored-by: ChampionAsh5357 <[email protected]>
@marchermans marchermans merged commit 840719e into neoforged:1.21.x Feb 6, 2025
6 checks passed
@neoforged-releases
Copy link

🚀 This PR has been released as NeoForge version 21.4.86-beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marchermans marchermans marchermans approved these changes

@ChampionAsh5357 ChampionAsh5357 ChampionAsh5357 approved these changes

Assignees
No one assigned
Labels
1.21.4 Targeted at Minecraft 1.21.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@YocyCraft @CLAassistant @marchermans @ChampionAsh5357