Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.20.6] Add ComponentItemHandler for using IItemHandlerModifiable with Data Components #990

Merged

Conversation

Shadows-of-Fire
Copy link
Contributor

This PR adds the new ComponentItemHandler class for out-of-the-box handling of IItemHandlerModifiable with data components, since ItemStackHandler is no longer suitable for this purpose.

This class was adapted from the prior implementation (ShulkerItemStackInvWrapper) and generified to any DataComponentType<ItemContainerContents> as well as improved to reduce the number of component accesses. Shulkers have been updated to use ComponentItemHandler instead of their own special-purpose handler.

This is the IItemHandler analogue to #985.

@Shadows-of-Fire Shadows-of-Fire added enhancement New (or improvement to existing) feature or request 1.20.6 Targeted at Minecraft 1.20.6 labels May 22, 2024
@Shadows-of-Fire Shadows-of-Fire self-assigned this May 22, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented May 22, 2024

  • Publish PR to GitHub Packages

Last commit published: 071579b3ff2a463cac1cfae4ea3de05ec6da28ca.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #990' // https://github.com/neoforged/NeoForge/pull/990
        url 'https://prmaven.neoforged.net/NeoForge/pr990'
        content {
            includeModule('net.neoforged', 'testframework')
            includeModule('net.neoforged', 'neoforge')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr990.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr990
cd NeoForge-pr990
curl -L https://prmaven.neoforged.net/NeoForge/pr990/net/neoforged/neoforge/20.6.84-beta-pr-990-component-item-handler/mdk-pr990.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@Shadows-of-Fire Shadows-of-Fire merged commit 8a7c09c into neoforged:1.20.x May 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.20.6 Targeted at Minecraft 1.20.6 enhancement New (or improvement to existing) feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants