Skip to content

Commit

Permalink
neonvm-controller: bring back RecordSuccess for conflicting (#957)
Browse files Browse the repository at this point in the history
The commit below has changed how the failing VMs are tracked:

    commit 3ac5841
    Author: Oleg Vasilev <[email protected]>
    Date:   Fri Jun 7 22:19:47 2024 +0400

neonvm-controller: replace failing reconciliation with per-VM failure
interval (#949)

The commit accidentaly lost a line which was meant to reset conflicting
status, which resulted in an ever-increasing number of conflicting VMs.

Fix this.

Signed-off-by: Oleg Vasilev <[email protected]>
  • Loading branch information
Omrigan authored Jun 10, 2024
1 parent 3ac5841 commit 7af1eb9
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions neonvm/controllers/metrics.go
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,7 @@ func (d *wrappedReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ct
"duration", duration.String(), "outcome", outcome)
} else {
d.failing.RecordSuccess(req.NamespacedName)
d.conflicting.RecordSuccess(req.NamespacedName)
log.Info("Successful reconciliation", "duration", duration.String())
}
d.Metrics.ObserveReconcileDuration(outcome, duration)
Expand Down

0 comments on commit 7af1eb9

Please sign in to comment.