Skip to content

Commit

Permalink
neonvm: Rename 'runner' container to 'neonvm-runner' (#277)
Browse files Browse the repository at this point in the history
Currently "runner" makes it hard to understand the log output of other
systems (e.g. k8s events) interacting with NeonVM. IMO renaming should
help make things more understandable to others.

Requires updating some Grafana dashboards.
  • Loading branch information
sharnoff authored May 24, 2023
1 parent 23a2a12 commit 9ea96b7
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions neonvm/controllers/virtualmachine_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -832,7 +832,7 @@ func podSpec(virtualmachine *vmv1.VirtualMachine) (*corev1.Pod, error) {
},
Containers: []corev1.Container{{
Image: image,
Name: "runner",
Name: "neonvm-runner",
ImagePullPolicy: corev1.PullIfNotPresent,
// Ensure restrictive context for the container
// More info: https://kubernetes.io/docs/concepts/security/pod-security-standards/#restricted
Expand Down Expand Up @@ -968,7 +968,7 @@ func podSpec(virtualmachine *vmv1.VirtualMachine) (*corev1.Pod, error) {
if pod.ObjectMeta.Annotations == nil {
pod.ObjectMeta.Annotations = map[string]string{}
}
pod.ObjectMeta.Annotations["kubectl.kubernetes.io/default-container"] = "runner"
pod.ObjectMeta.Annotations["kubectl.kubernetes.io/default-container"] = "neonvm-runner"

// use multus network to add extra network interface
if virtualmachine.Spec.ExtraNetwork != nil {
Expand Down

0 comments on commit 9ea96b7

Please sign in to comment.