Skip to content

Commit

Permalink
release: remove load: true from docker/build-push-action
Browse files Browse the repository at this point in the history
We seem to have gotten away with not loading before, and trying to set
both load=true and push=true results in

  Error: buildx failed with: ERROR: push and load may not be set together at the moment

There's basically no information available online about this, and it
*seems* to just be a current limitation of build-push-action? Looking
into the source did not illuminate anything.

We were previously just using push=true (both here and in
neondatabase/neonvm), so this commit switches back to that.
  • Loading branch information
sharnoff committed Mar 29, 2023
1 parent 6a150fd commit a7d5ec0
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ jobs:
context: .
platforms: linux/amd64
push: true
load: true
file: neonvm/runner/Dockerfile
tags: ${{ env.IMG_RUNNER }}:${{ steps.get_vcs_info.outputs.version }}

Expand All @@ -75,7 +74,6 @@ jobs:
context: .
platforms: linux/amd64
push: true
load: true
file: neonvm/Dockerfile
tags: ${{ env.IMG }}:${{ steps.get_vcs_info.outputs.version }}

Expand All @@ -85,7 +83,6 @@ jobs:
context: .
platforms: linux/amd64
push: true
load: true
file: neonvm/tools/vxlan/Dockerfile
tags: ${{ env.IMG_VXLAN }}:${{ steps.get_vcs_info.outputs.version }}

Expand Down Expand Up @@ -121,7 +118,6 @@ jobs:
with:
context: .
push: true
load: true
file: build/autoscale-scheduler/Dockerfile
tags: ${{ env.SCHED_IMAGE }}:${{ steps.get_vcs_info.outputs.version }}
build-args: |
Expand All @@ -131,7 +127,6 @@ jobs:
with:
context: .
push: true
load: true
file: build/autoscaler-agent/Dockerfile
tags: ${{ env.AGENT_IMAGE }}:${{ steps.get_vcs_info.outputs.version }}
build-args: |
Expand All @@ -141,7 +136,6 @@ jobs:
with:
context: .
push: true
load: true
file: build/vm-informant/Dockerfile
tags: ${{ env.INFORMANT_IMAGE }}:${{ steps.get_vcs_info.outputs.version }}
build-args: |
Expand Down

0 comments on commit a7d5ec0

Please sign in to comment.