agent: Send last billing/scaling events before shutdown #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No changes to the coverage.
HTML Report |
Omrigan
reviewed
Jan 27, 2025
Follow-up to #1107, ref #1220. In short, this change: 1. Moves reporting.EventSink's event sender thread management into a new Run() method 2. Calls (EventSink).Run() from (billing.MetricsCollector).Run(), appropriately canceling when done generating events, and waiting for it to finish before returning. 3. Adds (scalingevents.Reporter).Run() that just calls the underlying (EventSink).Run(), and calls *that* in the entrypoint's taskgroup. Or in other words, exactly what was suggested in this comment: #1221 (comment)
sharnoff
force-pushed
the
sharnoff/reporting-clean-shutdown
branch
from
cafbcd4 to
b4aed57
Compare
sharnoff
commented
Jan 29, 2025
Omrigan
reviewed
Jan 31, 2025
Omrigan
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1107, ref #1220.
In short, this change:
reporting.EventSink's event sender thread management into a newRun()method(EventSink).Run()from(billing.MetricsCollector).Run(), appropriately canceling when done generating events, and waiting for it to finish before returning.(scalingevents.Reporter).Run()that just calls the underlying(EventSink).Run(), and calls that in the entrypoint's taskgroup.Or in other words, exactly what was suggested here: #1221 (comment)