You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: guides/CODE_REVIEW.md
+6-4
Original file line number
Diff line number
Diff line change
@@ -25,14 +25,16 @@ This is probably the more common one that people think of when it comes to code
25
25
26
26
The key goals they need to ask themselves when reviewing code:
27
27
28
-
> Will this break production?
29
-
> Can someone else reasonably maintain this later?
28
+
> **Q1**: Will this break production?
29
+
>
30
+
> **Q2**: Can someone else reasonably maintain this later?
30
31
31
32
Sometimes a solution isn't exactly how you would expect it to be solved, that is ok. As a reviewer you should be open to letting these through. This is to help avoid nitpicking.
32
33
33
-
**Nitpicking should never block code getting released**.
34
+
⚠️ **Nitpicking should never block code getting released**. ⚠️
34
35
35
-
The regulating factor here is that if the code could not reasonably be maintained by someone else, then that is leaving tech debt and lowering the bar for the whole project.
36
+
The regulating factor is that if "_the code could not reasonably be maintained by someone else_", then that is leaving tech debt and lowering the bar for the whole project.
0 commit comments