Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration run in background mode #4226

Merged
merged 14 commits into from
Dec 26, 2023

Conversation

chenyukang
Copy link
Collaborator

@chenyukang chenyukang commented Nov 9, 2023

What problem does this PR solve?

Fix the issue that db migration may cost long time.
Fix #3683 by the way.

Problem Summary:

What is changed and how it works?

What's Changed:

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • Performance regression
  • Breaking backward compatibility

Release note

Title Only: Include only the PR title in the release note.

@chenyukang chenyukang requested a review from a team as a code owner November 9, 2023 23:48
@chenyukang chenyukang requested review from zhangsoledad and removed request for a team November 9, 2023 23:48
@chenyukang chenyukang force-pushed the yukang-add-background-migration branch 3 times, most recently from 39b22cf to 60ecbb9 Compare November 15, 2023 09:15
@chenyukang chenyukang force-pushed the yukang-add-background-migration branch 4 times, most recently from cc7222c to c77a927 Compare November 20, 2023 07:57
@eval-exec eval-exec self-requested a review November 20, 2023 07:57
@eval-exec eval-exec added the t:enhancement Type: Feature, refactoring. label Nov 20, 2023
@chenyukang chenyukang force-pushed the yukang-add-background-migration branch from c77a927 to 5d86765 Compare November 21, 2023 09:35
db-migration/src/lib.rs Outdated Show resolved Hide resolved
db-migration/src/lib.rs Outdated Show resolved Hide resolved
@chenyukang chenyukang force-pushed the yukang-add-background-migration branch from 9237e5f to f9dc6b9 Compare November 21, 2023 16:37
@chenyukang chenyukang force-pushed the yukang-add-background-migration branch from bac9780 to 7737319 Compare December 12, 2023 03:35
@chenyukang chenyukang added this pull request to the merge queue Dec 18, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 18, 2023
@chenyukang chenyukang force-pushed the yukang-add-background-migration branch from 7737319 to 49a4d58 Compare December 26, 2023 02:22
@chenyukang chenyukang force-pushed the yukang-add-background-migration branch from 49a4d58 to b38bc7a Compare December 26, 2023 02:38
@chenyukang chenyukang added this pull request to the merge queue Dec 26, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 26, 2023
@chenyukang chenyukang enabled auto-merge December 26, 2023 05:29
@chenyukang chenyukang added this pull request to the merge queue Dec 26, 2023
Merged via the queue into develop with commit dbb055d Dec 26, 2023
31 checks passed
@doitian doitian mentioned this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:enhancement Type: Feature, refactoring.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Guide users to re-sync only when migration fails.
3 participants