Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not wait unfinished tokio task if they does not exit after 20 seconds #4249

Closed
wants to merge 1 commit into from
Closed

Do not wait unfinished tokio task if they does not exit after 20 seconds #4249

wants to merge 1 commit into from

Conversation

eval-exec
Copy link
Collaborator

@eval-exec eval-exec commented Nov 27, 2023 •
edited
Loading

What problem does this PR solve?

This PR want to let CKB shutdown if there are some tokio tasks not exit after 20s

Related changes

  • when ckb received Ctrl-C signal, let ckb run shutdown if there are some tokio tasks not exit after 20s

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note 

Title Only: Include only the PR title in the release note.

@eval-exec eval-exec requested a review from a team as a code owner November 27, 2023 16:19
@eval-exec eval-exec requested review from quake and removed request for a team November 27, 2023 16:19
@eval-exec eval-exec marked this pull request as draft November 27, 2023 16:20
@eval-exec eval-exec force-pushed the exec/force-ckb-shutdown-when-some-tokio-tasks-exit-timeout branch 2 times, most recently from e06a424 to 24e4f22 Compare November 27, 2023 16:54
@eval-exec eval-exec force-pushed the exec/force-ckb-shutdown-when-some-tokio-tasks-exit-timeout branch from 24e4f22 to 3df2779 Compare November 27, 2023 17:10
@eval-exec eval-exec marked this pull request as ready for review November 27, 2023 17:10
@eval-exec eval-exec changed the title Do not wait unfinished tokio task if they does not exit after 30 seconds Do not wait unfinished tokio task if they does not exit after 20 seconds Nov 27, 2023
@eval-exec eval-exec mentioned this pull request Nov 27, 2023
Merged
@eval-exec eval-exec added s:waiting-on-reviewers Status: Waiting for Review s:pr-created Status: PR is ready for review labels Nov 28, 2023
@eval-exec eval-exec closed this Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenyukang chenyukang chenyukang approved these changes

@driftluo driftluo driftluo approved these changes

@quake quake Awaiting requested review from quake quake is a code owner automatically assigned from nervosnetwork/ckb-dev

@doitian doitian Awaiting requested review from doitian

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad

Assignees
No one assigned
Labels
s:pr-created Status: PR is ready for review s:waiting-on-reviewers Status: Waiting for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eval-exec @chenyukang @driftluo