chore: CKB Text Optimization #4250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EthanYuan
requested review from
zhangsoledad,
doitian,
chenyukang and
eval-exec
and removed request for
a team
EthanYuan
force-pushed
the
text-optimize
branch
from
e710632 to
a402984
Compare
EthanYuan
force-pushed
the
text-optimize
branch
from
a402984 to
c69de67
Compare
chenyukang
reviewed
Nov 29, 2023
chenyukang
approved these changes
Nov 29, 2023
EthanYuan
force-pushed
the
text-optimize
branch
from
c69de67 to
3666ab2
Compare
EthanYuan
force-pushed
the
text-optimize
branch
from
3666ab2 to
6db1982
Compare
|
The text extracted and modified falls into 4 categories, each saved in:
They are packaged into a zip file and archived under this PR: |
EthanYuan
force-pushed
the
text-optimize
branch
from
7c0ca8f to
84fd659
Compare
EthanYuan
force-pushed
the
text-optimize
branch
from
84fd659 to
b8c2698
Compare
zhangsoledad
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
CKB, being an executable program, produces a wide array of output messages during its runtime. These messages include console printouts, logs, error notifications, and text displayed within subcommands. These texts are authored by different developers at different stages of the development process, resulting in variations in language style and the possibility of syntax errors.
So, it is necessary to conduct an overall text review and optimization.
What is changed and how it works?
What's Changed:
We performed text extraction and editing based on revision 5975fda. Our professional writer has helped revise the text with existing issues. Many thanks to @linnnsss for the editing.
We utilized the text optimizer tool provided by #4189 to collect and format the text for organization. This made it possible for the writer to review. After the writer's editing, we employed the same tool for backfilling, resulting in the creation of this PR.
Related changes
Check List
Tests
Release note