Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetRpcImpl::get_peers return Remoteaddress.addresses dedup #4795

Merged
merged 1 commit into from
Jan 24, 2025
Merged

NetRpcImpl::get_peers return Remoteaddress.addresses dedup #4795

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions rpc/src/module/net.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ use ckb_systemtime::unix_time_as_millis;
use ckb_types::prelude::{Pack, Unpack};
use jsonrpc_core::Result;
use jsonrpc_utils::rpc;
use std::collections::HashSet;
use std::sync::Arc;

const MAX_ADDRS: usize = 50;
Expand Down Expand Up @@ -586,8 +587,9 @@ impl NetRpc for NetRpcImpl {
.connected_peers()
.iter()
.map(|(peer_index, peer)| {
let mut addresses = vec![&peer.connected_addr];
addresses.extend(peer.listened_addrs.iter());
let addresses: HashSet<_> = std::iter::once(peer.connected_addr.clone())
.chain(peer.listened_addrs.iter().cloned())
.collect();

let node_addresses = addresses
.iter()
Expand Down
Loading