-
Notifications
You must be signed in to change notification settings - Fork 243
Enhance ckb export/import subcommand with range and verifier selection
#4924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
eval-exec
wants to merge
16
commits into
nervosnetwork:develop
Choose a base branch
from
eval-exec:exec/enhance-import-export
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Enhance ckb export/import subcommand with range and verifier selection
#4924
eval-exec
wants to merge
16
commits into
nervosnetwork:develop
from
eval-exec:exec/enhance-import-export
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
627c4cf to
bbf2420
Compare
a409e5d to
06d221e
Compare
d3ffd22 to
4a627eb
Compare
6ea7b59 to
ce6dc5b
Compare
driftluo
reviewed
Aug 13, 2025
util/instrument/src/import.rs
Outdated
Comment on lines
167
to
176
| batch.par_iter().for_each(|line| { | ||
| let block: JsonBlock = | ||
| serde_json::from_str(line).expect("parse block from json"); | ||
| let block: Arc<core::BlockView> = Arc::new(block.into()); | ||
| blocks_tx.send(block).expect("send block to channel"); |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
serde-rs/json#635 Need to limit the number of parallel serde json, its memory usage is very large
Signed-off-by: Eval EXEC <[email protected]>
Signed-off-by: Eval EXEC <[email protected]>
Signed-off-by: Eval EXEC <[email protected]>
Signed-off-by: Eval EXEC <[email protected]>
Signed-off-by: Eval EXEC <[email protected]>
Signed-off-by: Eval EXEC <[email protected]>
Signed-off-by: Eval EXEC <[email protected]>
Signed-off-by: Eval EXEC <[email protected]>
2806821 to
25501d4
Compare
Collaborator
Author
[New LWP 1345358]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/nix/store/zdpby3l6azi78sl83cpad2qjpfj25aqx-glibc-2.40-66/lib/libthread_db.so.1".
Core was generated by `./target/ckb import -C /tmp/import /tmp/export/ckb-0-500000.jsonl --skip-all-verify'.
Program terminated with signal SIGABRT, Aborted.
#0 0x00007f80c9a99d1c in __pthread_kill_implementation () from /run/current-system/sw/share/nix-ld/lib/libc.so.6
[Current thread is 1 (Thread 0x7f80aafff6c0 (LWP 1345362))]
Python Exception <class 'ModuleNotFoundError'>: No module named 'libstdcxx'
(gdb) bt full
#0 0x00007f80c9a99d1c in __pthread_kill_implementation () from /run/current-system/sw/share/nix-ld/lib/libc.so.6
No symbol table info available.
#1 0x00007f80c9a41406 in raise () from /run/current-system/sw/share/nix-ld/lib/libc.so.6
No symbol table info available.
#2 0x00007f80c9a2893a in abort () from /run/current-system/sw/share/nix-ld/lib/libc.so.6
No symbol table info available.
#3 0x00005562906d11fb in rocksdb::port::Mutex::Lock() ()
No symbol table info available.
#4 0x0000556290583e68 in rocksdb::PeriodicTaskScheduler::Unregister(rocksdb::PeriodicTaskType) ()
No symbol table info available.
#5 0x0000556290471bee in rocksdb::DBImpl::CancelAllBackgroundWork(bool) ()
No symbol table info available.
#6 0x0000556290473663 in rocksdb::DBImpl::CloseHelper() ()
No symbol table info available.
#7 0x0000556290474549 in rocksdb::DBImpl::CloseImpl() ()
No symbol table info available.
#8 0x000055629049abf6 in rocksdb::DBImpl::~DBImpl() ()
No symbol table info available.
#9 0x000055629049bbe9 in rocksdb::DBImpl::~DBImpl() ()
No symbol table info available.
#10 0x00005562907a673f in rocksdb::OptimisticTransactionDBImpl::~OptimisticTransactionDBImpl() ()
No symbol table info available.
#11 0x0000556290453552 in rocksdb_optimistictransactiondb_close ()
No symbol table info available.
#12 0x000055628f0d89e3 in core::ptr::drop_in_place<ckb_rocksdb::optimistic_transaction_db::OptimisticTransactionDB> ()
No symbol table info available.
#13 0x000055628f0d8970 in alloc::sync::Arc<T,A>::drop_slow ()
No symbol table info available.
#14 0x000055628f7bce06 in core::ptr::drop_in_place<ckb_store::snapshot::StoreSnapshot> ()
No symbol table info available.
#15 0x000055628f7bccec in alloc::sync::Arc<T,A>::drop_slow ()
No symbol table info available.
#16 0x000055628f7884d1 in core::ptr::drop_in_place<ckb_snapshot::SnapshotMgr> ()
No symbol table info available.
#17 0x000055628f7845d0 in alloc::sync::Arc<T,A>::drop_slow ()
No symbol table info available.
#18 0x000055628efd62d1 in core::ptr::drop_in_place<ckb_shared::shared::Shared> ()
No symbol table info available.
#19 0x000055628efe32b9 in core::ptr::drop_in_place<ckb_chain::verify::ConsumeUnverifiedBlocks> ()
No symbol table info available.
#20 0x000055628efe20f9 in ckb_chain::verify::ConsumeUnverifiedBlocks::start ()
No symbol table info available.
#21 0x000055628efddc55 in std::sys::backtrace::__rust_begin_short_backtrace ()
No symbol table info available.
#22 0x000055628f06ff63 in core::ops::function::FnOnce::call_once{{vtable.shim}} ()
No symbol table info available.
#23 0x000055629014df3b in std::sys::pal::unix::thread::Thread::new::thread_start ()
No symbol table info available.
#24 0x00007f80c9a97ea3 in start_thread () from /run/current-system/sw/share/nix-ld/lib/libc.so.6
No symbol table info available.
#25 0x00007f80c9b1bdfc in __clone3 () from /run/current-system/sw/share/nix-ld/lib/libc.so.6
No symbol table info available.
(gdb) |
25501d4 to
832e33c
Compare
driftluo
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #4921
Problem Summary:
What is changed and how it works?
Related changes
ckb exportckb importCheck List
Tests
Side effects
Release note