Skip to content

Downgrade tokio from 1.48.0 to 1.44.2 by cargo update -p tokio --precise 1.44.2 #4992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Downgrade tokio from 1.48.0 to 1.44.2 by cargo update -p tokio --precise 1.44.2 #4992

wants to merge 1 commit into from

Conversation

@eval-exec
Copy link
Collaborator

@eval-exec eval-exec commented Oct 30, 2025 •
edited
Loading

What problem does this PR solve?

A performance regression has appeared on the develop branch — our analysis indicates it’s due to the Tokio upgrade.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • Fix Performance regression

Release note 

None: Exclude this PR from the release note.

@eval-exec eval-exec requested a review from a team as a code owner October 30, 2025 04:23
@eval-exec eval-exec requested review from doitian and removed request for a team October 30, 2025 04:23
@eval-exec eval-exec changed the title Downgrade tokio from 1.48.0 to 1.44.2 [Debug] Downgrade tokio from 1.48.0 to 1.44.2 Oct 30, 2025
@doitian doitian mentioned this pull request Oct 30, 2025
Closed
@eval-exec eval-exec changed the title [Debug] Downgrade tokio from 1.48.0 to 1.44.2 [Debug] Downgrade tokio from 1.48.0 to 1.44.2 by cargo update -p tokio --precise 1.44.2 Oct 30, 2025
@eval-exec eval-exec changed the title [Debug] Downgrade tokio from 1.48.0 to 1.44.2 by cargo update -p tokio --precise 1.44.2 Downgrade tokio from 1.48.0 to 1.44.2 by cargo update -p tokio --precise 1.44.2 Nov 6, 2025
@chenyukang
Copy link
Collaborator

chenyukang commented Nov 18, 2025

@eval-exec
do you have more details on the regression.
do you know which tokio version introduced the performance issue, since 1.44.2 to 1.48.0 there are several releases.
is there we possible we report a issue for upstream?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@doitian doitian Awaiting requested review from doitian doitian is a code owner automatically assigned from nervosnetwork/ckb-dev

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eval-exec @chenyukang