Refactor conditions to use metav1 condition#141
Open
phillebaba wants to merge 1 commit intonetbirdio:mainfrom
Open
Refactor conditions to use metav1 condition#141phillebaba wants to merge 1 commit intonetbirdio:mainfrom
phillebaba wants to merge 1 commit intonetbirdio:mainfrom
Conversation
phillebaba
force-pushed
the
refactor/conditions
branch
7 times, most recently
from
0ca6458 to
ff5de95
Compare
Signed-off-by: Philip Laine <philip.laine@gmail.com>
phillebaba
force-pushed
the
refactor/conditions
branch
from
ff5de95 to
da3e8ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change refactors the conditions used to use the standard metav1.Condition. Making it possible to use helper functions and standardize across the controller.