Remove option to disable http2 for metrics server#143
Merged
phillebaba merged 1 commit intonetbirdio:mainfrom Mar 18, 2026
Merged
Remove option to disable http2 for metrics server#143phillebaba merged 1 commit intonetbirdio:mainfrom
phillebaba merged 1 commit intonetbirdio:mainfrom
Conversation
Signed-off-by: Philip Laine <philip.laine@gmail.com>
phillebaba
force-pushed
the
enable-http2
branch
from
1877141 to
c26ca23
Compare
mlsmaycon
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTTP2 was disabled to mitigate security risks from CVE-2023-44487 and CVE-2023-39325 which have long since been fixed in Go. Removing the option that was false by default enables http2 and also reduces some confusion about why it is an option in the first place.