Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NAE-1862] Frontend update #186

Open
wants to merge 2 commits into
base: release/8.0.0
Choose a base branch
from
Open

[NAE-1862] Frontend update #186

wants to merge 2 commits into from

Conversation

renczesstefan
Copy link
Member

@renczesstefan renczesstefan commented Apr 15, 2023 •
edited by jira bot
Loading

Description

Update frontend to be compatible with backend.

Implements NAE-1862

Dependencies

No new dependencies were introduced.

Third party dependencies

No new dependencies were introduced.

Blocking Pull requests

There are no dependencies on other PR.

How Has Been This Tested?

This was tested manually and with unit tests.

Test Configuration

Name Tested on
OS macOS Ventura 13.1
Runtime Node 14.19.3
Dependency Manager NPM 6.14.17
Framework version Angular 13.3.1
Run parameters
Other configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes have been checked, personally or remotely, with @mazarijuraj
  • I have commented my code, particularly in hard-to-understand areas
  • I have resolved all conflicts with the target branch of the PR
  • I have updated and synced my code with the target branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes:
    • Lint test
    • Unit tests
    • Integration tests
  • I have checked my contribution with code analysis tools:
  • I have made corresponding changes to the documentation:
    • Developer documentation
    • User Guides
    • Migration Guides

@renczesstefan
[NAE-1862] Frontend update
aab88d3 
- updated naming conventions that were changed on backend
- changed request resource structures
- created new request resources
- corrected tests
@renczesstefan renczesstefan added improvement New feature or request Extra Large labels Apr 15, 2023
@renczesstefan renczesstefan self-assigned this Apr 15, 2023
@renczesstefan
[NAE-1862] Frontend update
1525893 
- modified request body for set data.
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

60.3% 60.3% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuplle tuplle Awaiting requested review from tuplle

@minop minop Awaiting requested review from minop

@Kovy95 Kovy95 Awaiting requested review from Kovy95

@machacjozef machacjozef Awaiting requested review from machacjozef

@mazarijuraj mazarijuraj Awaiting requested review from mazarijuraj

At least 1 approving review is required to merge this pull request.

Assignees

@renczesstefan renczesstefan

Labels
Extra Large improvement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@renczesstefan