-
Notifications
You must be signed in to change notification settings - Fork 4
[NAE-1892] Validation register #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/6.4.0
Are you sure you want to change the base?
Conversation
- implemented register for validations
# Conflicts: # docs/compodoc/components/js/search/search_index.js # docs/typedoc/components-core/modules.html # projects/nae-example-app/src/app/app.module.ts # projects/netgrif-components-core/src/lib/data-fields/boolean-field/models/boolean-field.ts # projects/netgrif-components-core/src/lib/data-fields/date-field/models/date-field.ts # projects/netgrif-components-core/src/lib/data-fields/date-time-field/models/date-time-field.ts # projects/netgrif-components-core/src/lib/data-fields/number-field/abstract-number-errors.component.ts # projects/netgrif-components-core/src/lib/data-fields/number-field/currency-number-field/abstract-currency-number-field.component.ts # projects/netgrif-components-core/src/lib/data-fields/number-field/number-default-field/abstract-default-number-field.component.ts # projects/netgrif-components-core/src/lib/data-fields/text-field/abstract-dashboard-text-field.component.ts # projects/netgrif-components-core/src/lib/data-fields/text-field/abstract-text-errors.component.ts # projects/netgrif-components-core/src/lib/data-fields/text-field/dashboard-bar-chart-text-field/abstract-dashboard-bar-chart-text-field.component.ts # projects/netgrif-components-core/src/lib/data-fields/text-field/dashboard-iframe-text-field/abstract-dashboard-iframe-text-field.component.ts # projects/netgrif-components-core/src/lib/data-fields/text-field/dashboard-line-chart-text-field/abstract-dashboard-line-chart-text-field.component.ts # projects/netgrif-components-core/src/lib/data-fields/text-field/dashboard-pie-chart-text-field/abstract-dashboard-pie-chart-text-field.component.ts # projects/netgrif-components-core/src/lib/data-fields/text-field/dashboard-portal-text-field/abstract-dashboard-portal-text-field.component.ts # projects/netgrif-components-core/src/lib/data-fields/text-field/html-textarea-field/abstract-html-textarea-field.component.ts # projects/netgrif-components-core/src/lib/data-fields/text-field/password-text-field/abstract-password-text-field.component.ts # projects/netgrif-components-core/src/lib/data-fields/text-field/rich-textarea-field/abstract-rich-textarea-field.component.ts # projects/netgrif-components-core/src/lib/data-fields/text-field/simple-text-field/abstract-simple-text-field.component.ts # projects/netgrif-components-core/src/lib/data-fields/text-field/textarea-field/abstract-textarea-field.component.ts # projects/netgrif-components-core/src/lib/data-fields/time-instance-abstract-field/abstract-time-instance-field.component.ts # projects/netgrif-components-core/src/public-api.ts
- implemented register for validations - implemented validation interface - refactored abstract data field components
- modified components and translation
- modified tests
# Conflicts: # projects/netgrif-components-core/src/lib/data-fields/boolean-field/models/boolean-field.ts # projects/netgrif-components-core/src/lib/data-fields/models/abstract-data-field.ts # projects/netgrif-components/src/lib/data-fields/data-fields.module.ts # projects/netgrif-components/src/lib/data-fields/date-field/date-default-field/date-default-field.component.ts # projects/netgrif-components/src/lib/data-fields/date-time-field/date-time-default-field/date-time-default-field.component.ts
# Conflicts: # docs/compodoc/components/js/search/search_index.js # docs/typedoc/components-core/modules.html
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
SonarCloud Quality Gate failed.
|
🎉 All dependencies have been resolved ! |
# Conflicts: # projects/nae-example-app/src/app/app.module.ts # projects/netgrif-components-core/src/lib/data-fields/base-component/abstract-base-data-field.component.ts # projects/netgrif-components-core/src/lib/data-fields/boolean-field/models/boolean-field.ts # projects/netgrif-components-core/src/lib/data-fields/data-fields.module.ts # projects/netgrif-components-core/src/lib/data-fields/date-field/abstract-date-field.component.spec.ts # projects/netgrif-components-core/src/lib/data-fields/date-field/date-default-field/abstract-date-default-field.component.spec.ts # projects/netgrif-components-core/src/lib/data-fields/date-field/date-default-field/abstract-date-default-field.component.ts # projects/netgrif-components-core/src/lib/data-fields/date-time-field/abstract-date-time-field.component.spec.ts # projects/netgrif-components-core/src/lib/data-fields/date-time-field/date-time-default-field/abstract-date-time-default-field.component.spec.ts # projects/netgrif-components-core/src/lib/data-fields/date-time-field/date-time-default-field/abstract-date-time-default-field.component.ts # projects/netgrif-components-core/src/lib/data-fields/models/abstract-data-field.ts # projects/netgrif-components-core/src/lib/data-fields/text-field/abstract-text-errors.component.ts # projects/netgrif-components-core/src/lib/data-fields/time-instance-abstract-field/abstract-time-instance-field.component.ts # projects/netgrif-components-core/src/lib/data-fields/time-instance-abstract-field/models/abstract-time-instance-field.ts # projects/netgrif-components-core/src/lib/data-fields/user-field/user-default-field/abstract-user-default-field.component.ts # projects/netgrif-components-core/src/lib/registry/public-api.ts # projects/netgrif-components-core/src/lib/task-content/services/field-converter.service.ts # projects/netgrif-components-core/src/lib/task-content/services/task-content.service.ts # projects/netgrif-components/src/lib/data-fields/data-fields.module.ts # projects/netgrif-components/src/lib/data-fields/date-field/date-default-field/date-default-field.component.ts # projects/netgrif-components/src/lib/data-fields/date-time-field/date-time-default-field/date-time-default-field.component.ts
- merge with 6.4.0
- merge with 6.4.0
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
1 similar comment
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
# Conflicts: # projects/nae-example-app/src/app/app.module.ts # projects/netgrif-components-core/src/lib/data-fields/i18n-field/i18n-text-field/abstract-i18n-text-field.component.ts
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
# Conflicts: # projects/netgrif-components-core/src/lib/data-fields/case-ref-field/case-ref-default/case-ref-default.component.ts # projects/netgrif-components-core/src/lib/data-fields/enumeration-field/enumeration-caseref-field/abstract-enumeration-caseref-field.component.ts # projects/netgrif-components-core/src/lib/data-fields/file-field/file-default-field/abstract-file-default-field.component.ts # projects/netgrif-components-core/src/lib/data-fields/file-list-field/file-list-default-field/abstract-file-list-default-field.component.ts # projects/netgrif-components-core/src/lib/data-fields/multichoice-field/multichoice-caseref-field/abstract-multichoice-caseref-field.component.ts # projects/netgrif-components-core/src/lib/data-fields/string-collection-field/string-collection-default-field/abstract-string-collection-default-field.component.ts # projects/netgrif-components-core/src/lib/task-content/services/field-converter.service.ts # projects/netgrif-components/src/lib/data-fields/data-fields.module.ts
- updated according to PR
|
Description
Implemented validation register.
Implements NAE-1892
Dependencies
No new dependencies were introduced.
Third party dependencies
No new dependencies were introduced.
Blocking Pull requests
Depends on #198 - PR 198 must be merged before this.
How Has Been This Tested?
This was tested manually and with unit tests.
Test Configuration
Netgrif Frontend PR Config
Checklist: