[NAE-2034] Open first view #261
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- implement resolving of auto-select views in double-drawer
- abstract loading and navigation in double drawer menu - implement default view opening in double drawer menu
Retoocs
added
improvement
Retoocs
requested review from
camperko,
Kovy95,
SamuelPalaj,
MartinSiran and
mazarijuraj
Kovy95
previously approved these changes
Jan 30, 2025
- update tests according to changes
mazarijuraj
previously approved these changes
Feb 11, 2025
Kovy95
reviewed
Feb 12, 2025
| NavigationItem, | ||
| RIGHT_SIDE_INIT_PAGE_SIZE, SETTINGS_TRANSITION_ID, | ||
| UriNodeResource | ||
| } from '../../public-api'; |
There was a problem hiding this comment.
dont import from public-api, change it to specific files
- update imports in double-drawer-navigation.service - add event emit in double-drawer-navigation.service
|
SamuelPalaj
reviewed
Feb 13, 2025
| if (!node) { | ||
| return; | ||
| } | ||
| if (node.parentId && !node.parent) { |
There was a problem hiding this comment.
Can the condition be flipped to get rid of nesting if clauses?
SamuelPalaj
reviewed
Feb 13, 2025
| let itemsWithView: Array<NavigationItem> = allItems.filter(item => DoubleDrawerUtils.hasItemView(item)); | ||
| if (itemsWithView.length > 0) { | ||
| this._redirectService.redirect(autoOpenItems[0].routing.path); | ||
| return; |
There was a problem hiding this comment.
Isn`t this return redundant?
Kovy95
approved these changes
Feb 13, 2025
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented rule, that selects particular view of the menu item when clicked on folder or initialized menu. Also moved the code, that load and navigates through the menu in separate service and utils. This service holds the menu resources.
Implements NAE-2034
Dependencies
No dependency
Third party dependencies
No new dependencies were introduced
Blocking Pull requests
There are no dependencies on other PR
How Has Been This Tested?
Manually and by tests
Test Configuration
Checklist: