Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Etag in image function #372

Closed
ascorbic opened this issue May 31, 2021 · 2 comments · Fixed by #375
Closed

Use Etag in image function #372

ascorbic opened this issue May 31, 2021 · 2 comments · Fixed by #375

Comments

@ascorbic
Copy link
Contributor

The image function should generate and return an Etag from the image buffer, and send a 304 response if the client has sent the same one
@ascorbic
Copy link
Contributor Author

ascorbic commented Jun 2, 2021

Realise my brain isn't working and this won't work, because we can't use headers in ODB

@ascorbic ascorbic closed this as completed Jun 2, 2021
@ascorbic
Copy link
Contributor Author

ascorbic commented Jun 2, 2021

Re-opening because it turns out it does handle etags!

@ascorbic ascorbic reopened this Jun 2, 2021
@ascorbic ascorbic mentioned this issue Jun 2, 2021
Merged
serhalp pushed a commit that referenced this issue Apr 5, 2024
@lukasholzer
feat: add build time o11ty to the runtime (#372)
93036f7 
* feat: instrument the build time aspect of the new runtime as well

* chore: improve traces

* chore: PR feedback

* chore: fix linting

* chore: remove recursive span as it creates a lot of spans
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add etag to image function opennextjs/opennextjs-netlify
1 participant
@ascorbic