Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add etag to image function #375

Merged
merged 1 commit into from
Jun 2, 2021
Merged

feat: add etag to image function #375

merged 1 commit into from
Jun 2, 2021

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Jun 2, 2021

Adds an etag header to images. We don't handle sending 304 responses because this is handled for us with an ODB
Fixes #372

@github-actions github-actions bot added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Jun 2, 2021
lindsaylevine
lindsaylevine approved these changes Jun 2, 2021
View reviewed changes
Copy link

@lindsaylevine lindsaylevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rad!! only comment is to maybe rebase or squash and merge since there seem to be 2 identical feat commits

@ascorbic ascorbic merged commit 15d15b3 into main Jun 2, 2021
@ascorbic ascorbic deleted the image-etags branch June 2, 2021 13:14
serhalp pushed a commit that referenced this pull request Jun 13, 2024
@pieh
chore: add rule to prevent 'floating' promises (#375)
db5d451
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindsaylevine lindsaylevine lindsaylevine approved these changes

@mraerino mraerino Awaiting requested review from mraerino

Assignees
No one assigned
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Etag in image function
2 participants
@ascorbic @lindsaylevine