Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle errors when loading next.config.js #79

Closed
ehmicky opened this issue Jan 8, 2021 · 4 comments · Fixed by #99
Closed

Handle errors when loading next.config.js #79

ehmicky opened this issue Jan 8, 2021 · 4 comments · Fixed by #99
Labels
type: bug code to address defects in shipped code

Comments

@ehmicky
Copy link

ehmicky commented Jan 8, 2021 •
edited
Loading

There are many reasons why loading next.config.js might fail such as:

  • Invalid configuration value (example)
  • Syntax error (example)
  • General error in the JavaScript logic, throwing an exception (example)

Those errors are currently reported as plugin bugs. We should report those as user errors instead by adding a try/catch + utils.build.failBuild() block.
@ehmicky ehmicky added the type: bug code to address defects in shipped code label Jan 8, 2021
@ehmicky
Copy link
Author

ehmicky commented Jan 19, 2021

Other example here:

Specified i18n.defaultLocale should be included in i18n.locales.
See more info here: https://err.sh/next.js/invalid-i18n-config

@lindsaylevine lindsaylevine mentioned this issue Feb 17, 2021
Merged
@ehmicky
Copy link
Author

ehmicky commented Mar 11, 2021 •
edited
Loading

This bug was fixed in #99 for:

https://github.com/netlify/netlify-plugin-nextjs/blob/61b61f57d58ae095e3522c86013c75823911179b/helpers/hasCorrectNextConfig.js#L17

However, the configuration is loaded also here:

https://github.com/netlify/netlify-plugin-nextjs/blob/61b61f57d58ae095e3522c86013c75823911179b/src/lib/helpers/getNextConfig.js#L11

We should use a similar try/catch/failBuild block there as well.

Bugsnag errors: one, two

@ehmicky ehmicky reopened this Mar 11, 2021
@ehmicky ehmicky mentioned this issue Mar 11, 2021
Merged
@ehmicky
Copy link
Author

ehmicky commented Mar 11, 2021

First part at #114

@ehmicky ehmicky mentioned this issue Mar 11, 2021
Merged
@ehmicky
Copy link
Author

ehmicky commented Mar 11, 2021

Fixed by #124.

@ehmicky ehmicky closed this as completed Mar 11, 2021
serhalp pushed a commit that referenced this issue Apr 5, 2024
@lukasholzer
fix: fixes an issue where the static pages could not be retrieved fro…
e18de13 
…m the blob store (#79)

* fix: fixes an issue where the static pages could not be retrieved from the blob store

* chore: update

* chore: update

* chore: update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug code to address defects in shipped code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fail build if plugin cant load next.config.js opennextjs/opennextjs-netlify
1 participant
@ehmicky