fail build if plugin cant load next.config.js #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindsaylevine
added
the
type: feature
lindsaylevine
force-pushed
the
ll/next-config-loading
branch
from
c844753 to
4a18b0f
Compare
erezrokah
suggested changes
Feb 17, 2021
| @@ -5,15 +5,15 @@ const isStaticExportProject = require('./isStaticExportProject') | |||
| const doesSiteUseNextOnNetlify = require('./doesSiteUseNextOnNetlify') | |||
| const hasCorrectNextConfig = require('./hasCorrectNextConfig') | |||
|
|
|||
| const doesNotNeedPlugin = async ({ netlifyConfig, packageJson }) => { | |||
| const doesNotNeedPlugin = async ({ netlifyConfig, packageJson, utils }) => { | |||
There was a problem hiding this comment.
[dust] should we pass only failBuild
There was a problem hiding this comment.
i was trying to keep it on the same level as netlifyConfig and packageJson, as in they're all things that get passed to the different event handlers (i.e onBuild) so i think it's ok? will keep in mind tho going forward
Co-authored-by: Erez Rokah <[email protected]>
lindsaylevine
added a commit
that referenced
this pull request
Feb 18, 2021
serhalp
pushed a commit
that referenced
this pull request
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #78
Fixes #79
not 100% sure about trying to pass in the exact error from the catch into
failBuild, open to thoughts!