Skip to content
This repository was archived by the owner on Dec 12, 2022. It is now read-only.

Add a ByteBuffer based implementation of Buffer #37

Merged
merged 7 commits into from
Mar 19, 2021
Merged

Add a ByteBuffer based implementation of Buffer #37

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9570982
Add a ByteBuffer based implementation of Buffer
chrisvest Mar 18, 2021
ff66723
Make test-compilation and test-running pass
chrisvest Mar 18, 2021
6a6ecde
Use release version of Netty build
chrisvest Mar 19, 2021
eebdae8
Make sure checkstyle dependencies are in the docker layer cache
chrisvest Mar 19, 2021
56a131a
Fix test-compile
chrisvest Mar 19, 2021
1bf9429
Fix warning printed at test time
chrisvest Mar 19, 2021
66fbc44
Update docker layer cache workflow thing
chrisvest Mar 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,14 +123,13 @@
<compilerArgs>
<arg>--add-modules</arg>
<arg>jdk.incubator.foreign</arg>

<!--
These two are really only needed for test-compile, but the maven-compiler-plugin cannot express that
-->
<arg>--patch-module</arg>
<arg>io.netty.buffer=${io.netty:netty-buffer:test-jar:tests}</arg>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has to be placed in compilerArgs instead of the various testCompiler* configurations, because the latter cannot correctly handle space-separated argument-value pairs.

This is a maven-compiler-plugin limitation, that apache/maven-compiler-plugin#27 will hopefully solve.

</compilerArgs>
<!-- Add the test-jar classes to the io.netty.buffer module for test-compile. -->
<testCompilerArgument>
--patch-module io.netty.buffer=${io.netty:netty-buffer:test-jar:tests}
</testCompilerArgument>
<excludes>
<exclude>**/package-info.java</exclude>
</excludes>
</configuration>
</plugin>
<plugin>
Expand Down