Skip to content

Commit

Permalink
Use -DCMAKE_MSVC_RUNTIME_LIBRARY=MultiThreaded (#751)
Browse files Browse the repository at this point in the history
Motivation:

We should use Use -DCMAKE_MSVC_RUNTIME_LIBRARY=MultiThreaded as a
replacement for /MT

Modifications:

Use cmake specific flag

Result:

Cleanup build
  • Loading branch information
normanmaurer authored Oct 29, 2024
1 parent 1a15b39 commit 0dccd0a
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions codec-native-quic/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,9 @@
<cargoTarget>--target=${quicheTarget}</cargoTarget>
<quicheBuildDir>${quicheSourceDir}/target/${quicheTarget}/release</quicheBuildDir>
<cmakeAsmFlags />
<!-- On Windows, build with /MT for static linking -->
<cmakeCFlags>/MT</cmakeCFlags>
<cmakeCFlags />
<!-- Disable one warning to be able to build on windows -->
<cmakeCxxFlags>/MT /wd4091</cmakeCxxFlags>
<cmakeCxxFlags>/wd4091</cmakeCxxFlags>
<libssl>ssl.lib</libssl>
<libcrypto>crypto.lib</libcrypto>
<libquiche>quiche.lib</libquiche>
Expand Down Expand Up @@ -705,6 +704,7 @@
<env key="MACOSX_DEPLOYMENT_TARGET" value="${macosxDeploymentTarget}" />
<arg value="-DCMAKE_POSITION_INDEPENDENT_CODE=TRUE" />
<arg value="-DCMAKE_BUILD_TYPE=Release" />
<arg value="-DCMAKE_MSVC_RUNTIME_LIBRARY=MultiThreaded" />
<arg value="-DCMAKE_ASM_FLAGS=${cmakeAsmFlags}" />
<arg value="-DCMAKE_C_FLAGS_RELEASE=${cmakeCFlags}" />
<arg value="-DCMAKE_CXX_FLAGS_RELEASE=${cmakeCxxFlags}" />
Expand Down

0 comments on commit 0dccd0a

Please sign in to comment.