Skip to content

Task:49 Fix known vulnerabilities#1550

Open
dualBreath wants to merge 2 commits into
networkservicemesh:mainfrom
dualBreath:task/49_fix_vulnerabilities
Open

Task:49 Fix known vulnerabilities#1550
dualBreath wants to merge 2 commits into
networkservicemesh:mainfrom
dualBreath:task/49_fix_vulnerabilities

Conversation

@dualBreath

Copy link
Copy Markdown
Contributor

Description

networkservicemesh/.github#49

Issue link

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI

Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com>
@dualBreath

Copy link
Copy Markdown
Contributor Author

Before:
Screenshot 2023-11-09 at 16 21 35

After:
Screenshot 2023-11-09 at 16 15 28

@codecov

codecov Bot commented Nov 9, 2023

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@7e78948). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1550   +/-   ##
=======================================
  Coverage        ?   66.78%           
=======================================
  Files           ?      259           
  Lines           ?    12327           
  Branches        ?        0           
=======================================
  Hits            ?     8233           
  Misses          ?     3573           
  Partials        ?      521           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com>
@dualBreath

dualBreath commented Nov 16, 2023

Copy link
Copy Markdown
Contributor Author

Looks like failed test is unstable and unrelated to current changes:

--- FAIL: TestRecvfd (0.49s)
    --- FAIL: TestRecvfd/TestRecvfdClosesSingleFile (0.13s)
        testing.go:1446: race detected during execution of test
    testing.go:1446: race detected during execution of test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants