Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed workflow #1430

Merged
merged 7 commits into from
Jun 8, 2024
Merged

Fixed workflow #1430

merged 7 commits into from
Jun 8, 2024

Conversation

sreichel
Copy link
Collaborator

@sreichel sreichel commented Jun 8, 2024

Magerun pull-request check-list:

  • Pull request against develop branch (if not, just close and create a new one against it)
  • README.md reflects changes (if any)

Fixes broken workflow for v.20.1+

@sreichel sreichel changed the title Fix workflow Fixed workflow Jun 8, 2024
@cmuench
Copy link
Member

cmuench commented Jun 8, 2024

@sreichel Great! Looks like you fixed the technical issue of the ci pipeline.
And we found some new issues with PHP 8.2 by running the tests. 👍

@sreichel
Copy link
Collaborator Author

sreichel commented Jun 8, 2024

@cmuench i dont think its only related to php8.2 ... see linked issue.

@cmuench
Copy link
Member

cmuench commented Jun 8, 2024

@cmuench i dont think its related to php8.2 ... see linked issue.

@sreichel If the issue is in OpenMage then it's nice that we could find this here.
IMHO we can merge the changes here to develop branch and then wait for a fix in MageOS ... and then update the CI config to install the fixed versions.
What do you mean?

@sreichel
Copy link
Collaborator Author

sreichel commented Jun 8, 2024

@cmuench merging to develop should be okay. Maybe you want to test install-command in local environment before. Maybe i've missed something.

@cmuench
Copy link
Member

cmuench commented Jun 8, 2024

@sreichel LGTM

@cmuench cmuench merged commit 765fdd9 into netz98:develop Jun 8, 2024
7 of 19 checks passed
@sreichel sreichel deleted the fix-workflow branch June 8, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants