change analysis description to be nullable #452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyuyangh
requested changes
Oct 26, 2022
lyuyangh
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow analysis description to be nullable
When uploading custom analyses without descriptions, the following error will occur and the web will break down.
This is because Analysis's description property is fixed to
stringtype. Setting Analysis description to be nullable also makes it consistent with its SDK setting.Web chart title change
The chart title is
{metricName} by {analysisDescription}, and the default analyses's descriptions are the same as the corresponding feature descriptions. Since custom analysis description can be null, use the feature name as analysisDescription when analysis description is not defined.