implement update_overall_statistics() and refactor create_system #483
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #433
The goal of this PR is to refactor the DB operations used by
create_systems()
. The operations are split into three methods:Each method can be run multiple times without causing an issue. They can also be called in any order after the system has been created. This is necessary if we want to treat
overall_statistics
as cache (previously we were calling itsystem_info
andmetric_stats
). Following this PR, I will implement a system which callsupdate_overall_statistics()
to update the cache whenever necessary. Note that,update_overall_statistics()
doesn't clean up stale resources properly if it is called multiple times. It works for now because it is only called once for each system. This PR is already pretty big so I plan to handle it in the next PR.