-
Notifications
You must be signed in to change notification settings - Fork 15
[Transforms] Transform Args, Scheme, and Config #321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! a few comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two questions:
- How do we maintain the order of the transforms if multiple are being applied to a given input or weight?
- What utility will be inferring the transform size and if its right/left?
Signed-off-by: Kyle Sayers <[email protected]>
To answer the question, this function uses location and side to determine which of the weight to apply to: |
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks great, thank you for improving on the original design
great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Summary
ModuleTarget
, andTransformData
has been removed as well as thetransform_creation_args
andcall_args
fieldsq_attn
andk_cache
TransformArgs
TransformScheme
TransformationArgs
onto which the transformation will be appliedTransformConfig
config.json
fileExample: